aboutsummaryrefslogtreecommitdiff
path: root/Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms (follow)
AgeCommit message (Collapse)AuthorFilesLines
2020-08-31Fix 🩹 (almost) all warnings ⚠️ with default configuration (DIM=3, ↵Gravatar Luca Fedeli 2-1/+6
openMP+MPI, double precision, no advanced solvers, no QED, native output) (#1263) This PR should fix almost all the compilation warnings in the default configuration (DIM=3, openMP+MPI, double precision, no advanced solvers, no QED, native output...). Or at least it does that on my system (my compiler is `g++ (Ubuntu 9.3.0-10ubuntu2) 9.3.0` ). I have just two residual warnings: ### 1 ``` [ 89%] Building CXX object CMakeFiles/WarpX.dir/Source/Parser/wp_parser.lex.cpp.o wp_parser.lex.c:1356:17: warning: ‘void yyunput(int, char*)’ defined but not used [-Wunused-function] ``` I don't know if `yyunput(int, char*)` is there for a reason, even if it is not used. So I didn't do anything. ### 2 ``` [ 96%] Building CXX object CMakeFiles/WarpX.dir/Source/Utils/CoarsenIO.cpp.o /home/luca/Projects/warpx_dir/WarpX/Source/Particles/WarpXParticleContainer.cpp: In member function ‘void WarpXParticleContainer::AddNParticles(int, int, const ParticleReal*, const ParticleReal*, const ParticleReal*, const ParticleReal*, const ParticleReal*, const ParticleReal*, int, const ParticleReal*, int, int)’: /home/luca/Projects/warpx_dir/WarpX/Source/Particles/WarpXParticleContainer.cpp:102:44: warning: unused parameter ‘nattr’ [-Wunused-parameter] 102 | int nattr, const ParticleReal* attr, int uniqueparticles, int id) ``` The first line of `AddNParticles` is `BL_ASSERT(nattr == 1); //! @fixme nattr is unused below: false sense of safety` . So I thought that there might be something to fix here and I didn't do anything.
2020-08-24Fix some warnings (#1239)Gravatar Luca Fedeli 3-12/+36
This PR fixes the source of several compilation warnings. Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
2020-07-24Fix -Wextra-semi (#1207)Gravatar Axel Huebl 3-18/+18
Remove unnecessary semicolons (fix compiler warnings).
2020-07-22Cleaner calculation of the simulation timestep (#1031)Gravatar Remi Lehe 4-0/+82
* Cleaner calculation of the simulation timestep * Fix compilation errors * Remove specification of CKC solver in PSATD test * Correct calculation of dt * Fix compilation error * Cleaner calculation of the simulation timestep * Fix compilation errors * Remove specification of CKC solver in PSATD test * Correct calculation of dt * Fix compilation error * Cleanup for cylindrical * Change input of automated tests to preserve previous results * Fix import statement for cylindrical * Preserve dt for PML test * Move function documentation to WarpX.H * Update CMakeList * Update CFL in some tests * Apply suggestions from code review Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> * Fix compilation errors * Revert "Fix compilation errors" This reverts commit 56ef67f228269b266876629f49789d3afdbbc00b. * Fix compilation error * Add cmath headers Add directly used header files. * Fix Include Order Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
2020-05-13Allow to pass component in stencil templates (#1012)Gravatar Remi Lehe 3-70/+70
2020-03-30Remove compiler warnings (#843)Gravatar Edoardo Zoni 1-0/+6
* Fix compiler warnings with DIM=2 * Fix compiler warnings with USE_RZ=TRUE * Fix compiler warnings with USE_PSATD=TRUE and DIM=2 * Fix compiler warnings with USE_PSATD=TRUE and DIM=3 * Fix bug: discard only return value when calling DefineAndReturnParticleTile * Remove unused variables not triggering warnings
2020-02-28fixing bug in ckc (#760)Gravatar Revathi Jambunathan 1-10/+10
2020-02-25FDTD: Real Literals and Formatting (#736)Gravatar Axel Huebl 4-149/+176
Clean up `amrex::Real` literals (aka "numbers"). This avoids calculating a line in double precision and casting it down to `Real` on assignment. Also fixes some formatting issues. (Commit credited to Remi.) Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
2020-02-06Add Doxygen commentsGravatar Remi Lehe 4-2/+19
2020-02-06Correct errors in CKCGravatar Remi Lehe 1-0/+5
2020-02-06Explicitly use "Cartesian" in the name of algorithmsGravatar Remi Lehe 3-32/+24
2020-02-06Make calculation of CKC coefficients for const friendlyGravatar Remi Lehe 4-91/+73
2020-02-06Implement review commentsGravatar Remi Lehe 4-4/+4
2020-02-06Make on-axis condition more explicit in EvolveBGravatar Remi Lehe 1-21/+16
2020-01-31Correct name of Downward derivativeGravatar Remi Lehe 3-9/+9
2020-01-31Left-align pre-compiler directivesGravatar Remi Lehe 3-42/+42
2020-01-31Add `const` anotationsGravatar Remi Lehe 4-32/+32
2020-01-29Add copyrightsGravatar Remi Lehe 4-0/+28
2020-01-28Add commentsGravatar Remi Lehe 4-41/+98
2020-01-28Fix typo in cylindrical operatorGravatar Remi Lehe 1-2/+2
2020-01-27Fix cylindrical solverGravatar Remi Lehe 1-1/+1
2020-01-27Implement nodal solverGravatar Remi Lehe 1-0/+103
2020-01-27Fix compilation errorsGravatar Remi Lehe 1-0/+15
2020-01-27Implement cylindrical Yee algorithmGravatar Remi Lehe 1-58/+38
2020-01-26Started cylindrical implementationGravatar Remi Lehe 1-0/+103
2020-01-24Bug fixes for CKCGravatar Remi Lehe 1-4/+4
2020-01-24Added CKC algorithmGravatar Remi Lehe 1-0/+210
2020-01-13Correct compilation errorsGravatar Remi Lehe 1-19/+33
2020-01-10Start fixing compilation errorsGravatar Remi Lehe 1-35/+32
2020-01-10Update Evolve BGravatar Remi Lehe 1-5/+17
2020-01-10Started implementing finite difference solverGravatar Remi Lehe 1-0/+80
Added Yee algorithm