Age | Commit message (Collapse) | Author | Files | Lines |
|
* Python: Start 1D Support
Start supporting 1D builds in Python.
* Fix 1D: PML FillZero unused
... since PMLs are not yet supported in 1D.
* BeamRelevant: Fix unused p_pos0
* FromTXYEFileLaserProfile: Not Impl in 1D
* QED Schwinger: 1D not Implemented
Fix unused warnings, add aborts.
* 1D RealVect/IntVect: Initialization
Use explicit scalar constructors, no braces.
Fix warning in clang 10.
* 1D NCI Filter: Fix unused members & Init
Unimplemented, but throws warnings.
* PSATD: 1D not Implemented
- remove compile warnings
- start porting some parts
* NCIGodfreyFilter: Clean up 2D & Else
|
|
psatd.update_with_rho=0 (#2571)
|
|
* Proton-boron fusion: initialize alphas momentum assuming isotropy
* Remove constexpr underflow in single precision
* Update Source/Particles/Collision/BinaryCollision/ProtonBoronFusionInitializeMomentum.H
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
|
|
|
|
Add 1D output support with openPMD.
|
|
* Python: More Nullptr Checks
I am debugging a couple of crashes while mitigating CI.
One of them pointed to the locations here
(`ValueError: NULL pointer access`), so I decided to add some checks.
* Skip invalid tiles
* Skip Empty Tiles But Check Pointer
* Python: nullptr check in _array1d_from_pointer
Make the methods `get_particle_structs` and
`get_particle_boundary_buffer_structs` more robust.
|
|
Timers) (#2584)
|
|
* add github ci compile check for ascent
* now with less whitespace
* add ascent to insitu workflow
* Update .github/workflows/insitu.yml
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* more style
* try to run as existing user
* new container
* use env script
* path fix
* add ascent test
* fix space
* move test resources
* get into style
* style
* Ascent CI: Cleanup (#1)
- make sure inputs file stays up-to-date
- locate alongside example
* Update .github/workflows/insitu.yml
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update .github/workflows/insitu.yml
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* rename test file
* fix for cp
* improve color table for vol rendering
* now with rotation
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
Mark the Python meta-data as production/stable.
|
|
* With RZ PSATD, make blocking_factor a power of 2
* Fix typo
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
|
|
GCC warns in some versions on the access here, since it cannot figure out the runtime size of the vectors.
We can just replace `[]` with `.at()` to use a range-checked access that throws an exception instead of a segfault/UB when accessed out-of-bounds. In the preparation of the compute stencils, we don't have hot loops that benefit from non-range checked access, so that cost for improved safety is fine.
|
|
* Build System: Add 1D Geometry
* test PR
* test PR
* 1D cartesian yee algorithm
* fixed typo
* Fixes for PML
* 1D support related multiple changes
* Fix compilation
* change 1D to 1D_Z
* 1D Field Gather and typo fix
* 1D Charge Deposition
* Particle Pusher
* multiple changes related to 1D
* 1D diagnostics and initialization
* PlasmaInjector and PEC fixes for 1D
* clean-up delete diags file
* mobility 1D laser particle and bilinear filter
* deleted diags files
* update laser particle weight formula
* delete diags files
* Azure: Add 1D Cartesian Runner
* 1D fixes for FieldProbe
* Update Docs/source/developers/dimensionality.rst
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
* 1d laser injection and langmuir test input files
* 1d tests
* clean up : delete print statements
* analyse simulation result for laser injection and Langmuir tests
* EOL
* delete input files for which there are no automated tests
* delete input files for which there are no automated tests
* add ignore_unused to remove warnings
* remove space
* Fix compilation issues
* fix error : macro name must be an identifier
* Small bug fix
* cleanup Python script for analysis
* bug fix
* bug fix
* Update ParticleProbe: Check 1D in-domain
* Update Source/Make.WarpX
* Update .azure-pipelines.yml
* Add USE_OPENPMD=FALSE to .azure-pipeline.yml
* resolve conflict
* resolve conflict
* fix typo
* Correct out-of-bound access
* Fix Particle BC in WarpXParticleContainer and correct path to checksumAPI in python analysis scripts
* EOL
* Fix bug : accessing out of bound index of cell in 1D
* remove 1d test for cartesian3d
* Fix CI check
* Slight style change
* Address review comments
* Fix GPU compilation Filter.cpp
* Fix CI
* Fix Indentation
* Address review comments
* More consistent ifdef for dimension bigger than 1
* Update Examples/Tests/Langmuir/analysis_langmuir_multi_1d.py
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update GNUmakefile
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Regression/prepare_file_ci.py
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianCKCAlgorithm.H
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianNodalAlgorithm.H
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Filter/Filter.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Filter/Filter.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Filter/Filter.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Filter/Filter.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Initialization/PlasmaInjector.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Update Source/Initialization/PlasmaInjector.cpp
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* add comment inline to explain twice push_back
* Add amrex::Abort for NCIGodfreyFilter
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Prabhat Kumar <prabhatkumar@kraken.dhcp.lbl.gov>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <rlehe@lbl.gov>
|
|
* updated the Python particle attribute access CI test
* additional fixes needed for tests to pass
* changes requested by Axel during code review
* Apply suggestions from code review
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
* WarpX tests: All MPI
Enable MPI for the one regression test that does not use it.
Still uses one rank there.
This saves a compile per CI run.
* add numprocs
|
|
When python callbacks take some time, this is useful as otherwise many
callbacks are lumped together in WarpX::Evolve::step.
|
|
* WarpXComm.cpp: Use Explicit Types, not `auto`
* Use MultiFab* const instead of MultiFab* const&
|
|
* added helper function to rebuild MultiFabs and iMultiFabs during load balancing and included rebuilding of EB multifabs
* added redistribute call for the particle boundary buffer during load balancing
* consistently use DistribtionMap rather than dmap in ElectrostaticSolver.cpp
* applied suggested changes from code review by Phil Miller
* removed default argument for redistribute in RemakeMultiFab
* removed RemakeMultiFab() as a member of WarpX
* Only remake EB multifabs if they are used
Co-authored-by: Lorenzo Giacomel <47607756+lgiacome@users.noreply.github.com>
* adapted existing particle scraping test (PICMI version) to also cover the redistribution of particle buffers from load balancing
* added redeclaring of m_borrowing
* Move redeclaring of m_borrow inside if statement for ECT solver algorihtm
Co-authored-by: Lorenzo Giacomel <47607756+lgiacome@users.noreply.github.com>
* added calls to MarkCells and ComputeFaceExtensions
* fixed issue causing CI test to fail and copied conditionals from WarpXInitData.cpp to recompute EB quantities
* Guard cells communication for EB data when re-gridding (#105)
* Add 2D circle EB test (#2538)
* Added embedded_circle test
* Add embedded_circle test files
* Removed diag files
* removed PICMI input file
* Update to use default regression analysis
* Added line breaks for spacing
* Added description
* Fixed benchmark file
* Added load balancing to test
* Commented out load_balancing portion of test.
This will be added back in once load balancing is fixed.
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Added guard cells communication for EB data in regridding
Co-authored-by: Kevin Z. Zhu <86268612+KZhu-ME@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* moved all EB grid data calculations to a new function InitializeEBGridData() which is now called by both WarpX::InitLevelData and WarpX::RemakeLevel
* Fix typo in doc string.
Co-authored-by: Phil Miller <unmobile+gh@gmail.com>
Co-authored-by: Lorenzo Giacomel <47607756+lgiacome@users.noreply.github.com>
Co-authored-by: Kevin Z. Zhu <86268612+KZhu-ME@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Phil Miller <unmobile+gh@gmail.com>
|
|
|
|
|
|
On CPU links of the GNUmake Python lib, we forgot our `-g`, which we
add to all build and optimization types. THis is part of the
`LINKFLAGS` variable.
|
|
|
|
* Cell Center Macroscopic Properties
* Commit Suggestions from PR Review
* Fix Error for 2D
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
|
|
* Added embedded_circle test
* Add embedded_circle test files
* Removed diag files
* removed PICMI input file
* Update to use default regression analysis
* Added line breaks for spacing
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Added description
* Added Ar and Xe to pre-defined particle types
* added Boltzmann's constant to pre-defined constants and cleaned up the MCC CI test input
* Added Boltzmann's constant to warpx parser
* cleaned up embedded circle CI test input
* Remove duplicate entry.
Co-authored-by: kzhu-ME <kevin.zhu@modernelectron.com>
Co-authored-by: Kevin Z. Zhu <86268612+KZhu-ME@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
* Enhanced inline documentation of EB related data
* Added ECT to the glossary
* Made the EB documentation doxygen-compatible
|
|
* Refactoring the nborrow functions
* Refactoring the one cell extension
* Refactoring the eight cells extension
* Enabling 2D
* Bug fix
* Some more improvements
* Fixing templates
* Switching the order of templates and AMREX_GPU_DEVICE
* Adding the needed AMREX_GPU_DEVICE in WarpX.H
* Fixing GPU related issues
* Fixed a for loop bound
* Making the new functions free
* Suggestion from review
* Suggestion from review
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Suggestion from review
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Improve loops over dimensions for 2D
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
|
|
* Added embedded_circle test
* Add embedded_circle test files
* Removed diag files
* removed PICMI input file
* Update to use default regression analysis
* Added line breaks for spacing
* Added description
* Fixed benchmark file
* Added load balancing to test
* Commented out load_balancing portion of test.
This will be added back in once load balancing is fixed.
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
Fix an auto-converted label in a `.rst` file for the manual.
Remove the `PML.tex` file.
|
|
* AMReX: Weekly Update
* PICSAR: Weekly Update
|
|
* Fix conflict with upstream
* Apply suggestions from code review
* Remove space in the end of lines
* Include suggestions from PR review
* Generalize ROMIO Hints in Batch Scripts
* Fix Comment
* Fix Comment
* Remove duplication
* Formatting
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
* add remake of phi_fp during load balancing RemakeLevel
* added phi_cp remake to RemakeLevel function
* revert changes from previous commit
|
|
* Fix Instability in PML with PSATD
Damping in PML should be applied before the communications between the regular grids and PML, and between PML grids take place, otherwise the ghost cells are filled with lagged information, which results in an instability. Closes #2525.
* Update checksum of the pml_psatd_dive_divb_cleaning test
|
|
* adding the FieldProbe
* adding missing file
* updating makefile
* fixing host-device problem
* Revert "fixing host-device problem"
This reverts commit 801e6fc47f19cfc42ec46e5ef1a18dcf86be3e5a.
* fixing host-device problem
* making some variables const
* adding a few comments
* Adding the FieldProbe to the documentation
* making the probe mpi-safe
* added field probe to reduced diag test
* added field probe to reduced diag analysis
* using cell-centered fields in probe diag
* removed a few typos
* Interpolating to the point instead oof cell center
* bug fix
* improved a comment
* updated documentation
* Undone an outdated change
* improving some variable names
* improving the box extraction
* making the interpolation order an input parameter
* fix a typo
* setting the field values to zero if the point is not in the domain
* skipping the communication if probe proc is IO prcessor
* Fixed typo in documentation
Co-authored-by: Neïl Zaim <49716072+NeilZaim@users.noreply.github.com>
* Updating an header
* Added a comment on the probe position
* tidying up the analysis script
* fixed a comment
* removing an unused include
* improving the parsing of parameters
* fixing some comments
* making some variables const
* changed some ParticleReal into Real
* using better tags in MPI communication
* Making field probe work in 2D
* making a variable const
* initializing y_probe only in 3D
* tidying up a line which is common to 2D and 3D
* making a variable constexpr
* adding a _rt
* checking that the probe location is in one of the processors
* removing a useless if condition
* Fixing the initialization in 2D
* Avoiding scrape particles in 2D (it segfaults)
* Adding a test for 2D EB
* Fixed the areas initialization
* Initializing to zero some multifabs
* Modified the ECT solver to make it work in 2D
* Modified the cell extensions to make them work in 2D
* Improved 2D cube test
* Added 2D rotated cube test
* Adding the 2d analysis script and CI
* Removed an unused import from the analysis script
* Ignoring some unused variables
* Fixing the number of dimensions in the 2d test
* Added missing analysis for ECT
* Enabled again 2d particles scraping
* Fixing the test_name with the general logic
* Fixing the test_name with the general logic
* Removed some commented code
* Modified several preprocessor directives to check consistency EB-dimension
* Added missing semicolons
* Fixed a preprocessor directivew
* Fix typo: WARPX_DIM_XZ
* Improving some comments
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Adding some more consistency checks
* Adding some more consistency checks
* Fixed a typo
Co-authored-by: Neïl Zaim <49716072+NeilZaim@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
|
* Added Ar and Xe to pre-defined particle types
* Added Boltzmann's constant to warpx parser
* Updated documentation
|
|
Automatically copy and compile openPMD-api 0.14.3, but still supporting the 0.14.2+ range (#2150).
The 0.14.3 release solves ABI incompatibilities in C++14/17 mixed builds, among other issues (mainly read).
|
|
Add failure handling if inputs in `std::ifstream`s cannot be opened
or have problems seek-ing through them.
This should catch I/O errors early.
|
|
* Tests: numthreads to 1
We already hack this option to read `numthreads = 1` already for
benchmarks, thus we remove the confusing other values now.
* Prepare for CI: Do not Overwrite `numthreads`
|
|
We generally run only with one OpenMP threads at the moment, but
disabling OpenMP altogether causes an extra compile, which slows down
CI.
|
|
- Add macOS hints for OpenMP
- Add hints for running GNUmake regression tests locally
|
|
(#2536)
* #2534: Don't access position vector values beyond the configured dimension
* Fix particle position component used in XZ configuration
* Handle 1D case
* Move values only used in scraping function into inside-boundary condition
* Error out if scraping from EB in RZ
|
|
* Draw Gaussian beam position with amrex random engine
* Update benchmarks
* Update tolerance in space-charge tests
* Update benchmark for space charge initialization test
* Update benchmarks
* Update benchmark
* Clean-up code
* Update benchmarks
|
|
* make some code compilable with Fujitsu compiler in clang mode
* update documentation
|
|
Make sure `numpy` can be rebuilt when and were needed.
To achieve that, move numpy-specific installation hints on OpenBLAS
to the WarpX profile.
|
|
* Add pre-commit
Add basis for automated pre-commit checks.
Install locally via:
```bash
python3 -m pip install -U pre-commit
pre-commit install
```
See: https://pre-commit.com
* Cleanup: Whitespaces
* Cleanup: requirements.txt order
|
|
Weekly update to latest AMReX.
Weekly update to latest PICSAR (no changes).
```
./Tools/Release/updatePICSAR.py
./Tools/Release/updateAMReX.py
```
|
|
* Fix Bug with Tilebox for G in PML
* Reset Benchmark
|
|
|
|
buffers (#2498)
|
|
* PICMI: Add amr.max_grid_size_<x,y,z>
* Set All Flags in Python
* PICMI: Add amr.blocking_factor_<x,y,z>
|