Age | Commit message (Collapse) | Author | Files | Lines |
|
* merge
* wip
* namespace
* eol
* cost
* eol
* fix
* eol
|
|
* Docs: PSATD Runtime Option
* Tests: PSATD Runtime Option
Add new runtime option to PSATD regression test matrix.
* PICMI: PSATD runtime option
* Source: PSATD Runtime Option
|
|
* Implemented lab frame electrostatic model
* Small clean up of ComputeSpaceChargeField
* Added ElectrostaticSphereLabFrame regression test
|
|
* Rename Input to `algo.maxwell_solver`
Rename the input option `algo.maxwell_fdtd_solver` to
`algo.maxwell_solver` and throw a useful error message for users
using the old option.
This is in preparation to unify FDTD and PSATD input control to
reduce mutually exclusive binary variants of WarpX.
* MW Solver Name: Update Examples
Update all example to use the new algo.maxwell_solver option.
* Fix typo in comutation of dt
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
|
|
* Added stub for current correction in RZ spectral solver
* Start implementation of Vay deposition
* Continue implementation of Vay deposition
* Correct deposition of D
* Add phase shift for staggered currents
* Small clean-up
* Fix units in deposition of D
* Implement average of cumulative sum (needs bug fix)
* Start fixing bug in average of cumulative sum
* Still debugging
* Cumulative sums should be correct now
* Subtract averages of cumulative sums:
- current implementation: cumulative sums, inverse Fourier transform, subtraction of averages
- needs to be tested (including units of D after Vay deposition)
- needs to be shortened (too many loops over boxes and ParallelFors)
* [skip CI] Clean up and fix units
* Still fixing units
* [skip CI] Remove temporarily averages of cumulative sums
* [skip CI] Remove distinction between staggered and nodal
* Vay and Esirkepov similar results on periodic single box:
TODO:
- debug (charge not conserved);
- try using compute_shifted_shape_factor as in Esirkepov deposition;
- clean up;
- try on multiple boxes and with correction of mode at 0 frequency.
* [skip CI] Clean up
* Fix bug in 3D deposition
* [skip CI] Clean up
* Fix 2D and 3D implementation:
- simulation results agree between direct and Vay deposition in both 2D and 3D
- Travis CI tests should pass except for check of charge conservation (debug)
* Small clean-up
* Fix bug when compiling in RZ geometry
* Add benchmark json files (will be reset later)
* Do not set zero current at zero frequency
* [skip CI] Revert last commit and clean up
* Fix small bug after reverting commit
* Set nodal test first on Travis
* Fix benchmark for nodal test in 3D
* Fix particle output for nodal test in 3D
* Fix bugs due to staggering
* Rename current nodal Travis tests
* Add Travis tests staggered in 2D and 3D
* Further clean-up after bug fix
* Abort when using Vay deposition with domain decomposition
* Add optional argument of index type to forward FFT
* Fourier shifts can be private members as before
* Small clean-up
* Clean up and improve Doxygen documentation
* Fix small bug in analysis script for 2D tests
* Fix tests (remove E and B fields from particle diags)
* Add option to fill guard cells and docs
* Fix value of last guard cell by enforcing periodicity
* Revert changes merged from #1121
* Clean up style
* Improve docs
* Fix forgotten alignment
* Improve docs
* Make base class functions VayDeposition pure
Co-authored-by: Dave Grote <dpgrote@lbl.gov>
|
|
* Adding macro-E Push and new file
* Add macroEvolveE, call it, and include algo selection in utils
* fix eol
* Fixing bug in macroE for sigma method 1
* changing MacroEvolveE to MacroscopicEvolveE
* add class for macroscopicproperties and an object in WarpX class
* fix eol
* adding templated ckc call with comment that EvolveE is same for yee and ckc
* add header file pointing to ckc algorithm
* adding obejct m_macroscopic_properties to access sigma,eps,mu
* some cleaning
* Adding comments
* adding documentation
* spelling wandroff to wendroff
* fixing eol
* eol
* const in the right place. Thanks bot!
* profiler for macroscopic evolveE
* re-introduced deleted line when fixing conflict to declare templated EvolveBPMLCartesian function
* fixing if-else statement for RZ in MAcroscopicEvolveE.cpp
* adding suggestions and corrections made in PR review.
* fixing grammar in docs
* fix eol whitespace
* fix typo
|
|
* Issue #713: Load Balance w.r.t. number of cells + particles
README: Update Badged to `master` (#725)
* README: Update Badged to `master`
Update the badges to check the `master` branch as development branch.
* Docs: More dev->master updates
- release workflow
- contribution guide link
Galilean PSATD with shift (#704)
* Read Galilean velocity
* Prepare structures for Galilean solver
* Started implementing Galilean equations
* Analytical limits for X1, X2, X3, X4 coefficients added
* Slight changes added
* Added Galilean position pusher
* Scale galilean velocity
* Remove unneeded Abort
* Fix Galilean pusher
* Allocate Theta2 array
* Fix definition of coefficients
* Increase guard cells for Galilean
* Add guard cell in particle exchange
* Type corrected
* v_gal added to warpx_current_deposition
* v_gal added to WarpXParticleContainer.H
* Bug fixed - update particle x-position over one time step
* Fix issues with merge from dev
* Preparation for merging dev into galilean.
* Adding galilean shift
* Implemented galilean shift
* Changed method's name from GalileanShift to ShiftGalileanBoundary
* Added doxygen string for ShiftGalileanBoundary
* Removed never used method LowerCornerWithCentering
* Removed temporary comments
* Removed dt as a variable from DepositCharge method and its dependencies
* Converted tab to spaces
* Removed EOL white space
* Add documentation and automated tests
* Fix compilation error
* Add automated test
* Update automated test
* Removed temporary used galilean shift
* Removed temporary used particle's push for Galilean PSATD
* Removed unused statement
* Remove EOL white space.
* Added zero shift for LowerCorner in RZ geometry
* Minor changes to Galilean implementation
* Modifications for GPU
* Fix typo
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
[mini-PR] when a cufft error occurs, print a meaningful error message (#728)
* added method to translate cufft errors
* fixed style
* bug fixing
avoid duplicate tests and plot less often (#726)
* avoid duplicate tests and plot less often
* fix tests I broke when trying to save plotfiles
doc install yt on Summit (#729)
* doc install yt on Summit
* eol
Do not use local Redistribute for electrostatic solver (#731)
Add Reset Random Seed Feature (#717)
* Add ResetRandomSeed
* Add doc
* Modify and change location of the code.
* Small fix
* Try to fix an alert
* Try to fix an alert
* Modify based on suggestions
* Use INT_MAX
* Modify based on suggestions.
* Modify based on suggestions.
openPMD: warn if step is already written (#718)
* making sure iterations are written at most once.
* prints a warning when iteration is written more than once
writting is not stopped
* Fixed tabs
* included <iostream> as requested by Axel
Minor refactoring of space-charge calculation (#732)
Improve clarity and documentation
Minor
Update GNUmakefile
Update based on comments
Update GNU Makefile
Formatting
Formatting
Formatting
Formatting
Remove unneeded function
Removed unneeded function
Formatting
Formatting
Formatting
Whitespace
Minor
Formatting
Formatting
Formatting
Formatting
Formatting
Formatting
Formatting
whitespace
Formatting
Minor
Formatting
Remove unneeded template function
Change import
Minor
Formatting
Remove unused variable
Formatting
Update Source/WarpX.H
Co-Authored-By: MaxThevenet <mthevenet@lbl.gov>
Update Source/Parallelization/WarpXRegrid.cpp
Co-Authored-By: MaxThevenet <mthevenet@lbl.gov>
Remove `n_particles` and `n_cells`
Update Source/WarpX.H
Co-Authored-By: MaxThevenet <mthevenet@lbl.gov>
Revert clear costs in case of edge case
Update to use new load_balance_api in AMReX
Tabs
Minor
* minor: indentation in Source/WarpX.H
Co-authored-by: MaxThevenet <mthevenet@lbl.gov>
|
|
- Use `""` for WarpX-local includes
- Order: WarpX `""`, AMReX `<>`, other third party includes `<>`
- Add dir prefixes for WarpX
Add order to includes by including from `Source/` onward and keeping
directory prefixes of non-local includes for clarity.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
A typical include order in C++ is:
- "module header" (local header)
- "own headers" (WarpX)
- <close library headers> (AMReX)
- <other third party headers> (e.g. omp)
- <stdlib headers>
This avoids that a "forgotten include" will silently compile
in some compilers and crash in others (because it will crash
in all).
References:
- https://llvm.org/docs/CodingStandards.html#include-style
- https://include-what-you-use.org
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|