From 297dd2d31527acc9676d4eb0c3a9c54c2688abd6 Mon Sep 17 00:00:00 2001 From: Luca Fedeli Date: Tue, 13 Jun 2023 05:07:42 +0200 Subject: Enforce const correctness using clang-tidy CI test (#3921) * add clang-tidy workflow * fix missing newline * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make clang.14.sh executable * remove non explicitly selected checks * complete list of dependencies * fix bug * specify path of clang-tidy file * fix bug * add new check * remove one check * add magic numbers check * removed one check * keep only one check * Docs: Conda Dev w/ Boost (#3911) Add the `boost` package to the conda developer environment. Used for QED table generation. * Fix typo in Adastra cluster documentation (#3918) * add back three checks * prepare clang-tidy wrapper * actually use clang-tidy in the script * test * fix bug * actually use clang-tidy * fixed bug * fixed bug * fixed bug * fixed bug * remove all checks except the selected 3 * fixed bug * fixed bug * fixed bug * enforce const correctness using clang-tidy * remove one check * Fix Concurrency Issue * BLAS++/LAPACK++ for RZ+PSATD * Build all 4 WarpX DIMS * add few echo for test purposes * try to debug mysterious error * don't test RZ with clang-tidy * add back RZ test * add some const * fix bug * check also header files * remove header filter since it does not work as expected * fixed bug * check also WarpX headers * fix bugs * continue enforcing const correctness * continue enforcing const correctness * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed bug * fix bugs and add new const * clean .clang-tidy * make regex more precise according to Weiqun's suggestion * add more const * fix bugs * fix bug * silence warning on float comparison * fixed bug * fixed bugs * fix bug and add const * fixed bugs * fix bug * fix bug * fix bug * fixed bug * fix bug --- .../SpectralAlgorithms/PsatdAlgorithmComoving.cpp | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.cpp') diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.cpp b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.cpp index eb7e1578e..37bbc2ca3 100644 --- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.cpp +++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.cpp @@ -75,15 +75,15 @@ PsatdAlgorithmComoving::pushSpectralFields (SpectralFieldData& f) const const amrex::Box& bx = f.fields[mfi].box(); // Extract arrays for the fields to be updated - amrex::Array4 fields = f.fields[mfi].array(); + const amrex::Array4 fields = f.fields[mfi].array(); // Extract arrays for the coefficients - amrex::Array4 C_arr = C_coef [mfi].array(); - amrex::Array4 S_ck_arr = S_ck_coef[mfi].array(); - amrex::Array4 X1_arr = X1_coef [mfi].array(); - amrex::Array4 X2_arr = X2_coef [mfi].array(); - amrex::Array4 X3_arr = X3_coef [mfi].array(); - amrex::Array4 X4_arr = X4_coef [mfi].array(); + const amrex::Array4 C_arr = C_coef [mfi].array(); + const amrex::Array4 S_ck_arr = S_ck_coef[mfi].array(); + const amrex::Array4 X1_arr = X1_coef [mfi].array(); + const amrex::Array4 X2_arr = X2_coef [mfi].array(); + const amrex::Array4 X3_arr = X3_coef [mfi].array(); + const amrex::Array4 X4_arr = X4_coef [mfi].array(); // Extract pointers for the k vectors const amrex::Real* modified_kx_arr = modified_kx_vec[mfi].dataPtr(); @@ -178,13 +178,13 @@ void PsatdAlgorithmComoving::InitializeSpectralCoefficients (const SpectralKSpac const amrex::Real* kz = kz_vec[mfi].dataPtr(); // Extract arrays for the coefficients - amrex::Array4 C = C_coef [mfi].array(); - amrex::Array4 S_ck = S_ck_coef [mfi].array(); - amrex::Array4 X1 = X1_coef [mfi].array(); - amrex::Array4 X2 = X2_coef [mfi].array(); - amrex::Array4 X3 = X3_coef [mfi].array(); - amrex::Array4 X4 = X4_coef [mfi].array(); - amrex::Array4 T2 = Theta2_coef[mfi].array(); + const amrex::Array4 C = C_coef [mfi].array(); + const amrex::Array4 S_ck = S_ck_coef [mfi].array(); + const amrex::Array4 X1 = X1_coef [mfi].array(); + const amrex::Array4 X2 = X2_coef [mfi].array(); + const amrex::Array4 X3 = X3_coef [mfi].array(); + const amrex::Array4 X4 = X4_coef [mfi].array(); + const amrex::Array4 T2 = Theta2_coef[mfi].array(); // Store comoving velocity const amrex::Real vx = m_v_comoving[0]; @@ -254,7 +254,7 @@ void PsatdAlgorithmComoving::InitializeSpectralCoefficients (const SpectralKSpac if ( (nu != om_mod/om) && (nu != -om_mod/om) && (nu != 0.) ) { - Complex x1 = om2 / (om2_mod - nu * nu * om2) + const Complex x1 = om2 / (om2_mod - nu * nu * om2) * (theta_star - theta * C(i,j,k) + I * nu * om * theta * S_ck(i,j,k)); // X1 multiplies i*(k \times J) in the update equation for B @@ -424,7 +424,7 @@ void PsatdAlgorithmComoving::CurrentCorrection (SpectralFieldData& field_data) const amrex::Box& bx = field_data.fields[mfi].box(); // Extract arrays for the fields to be updated - amrex::Array4 fields = field_data.fields[mfi].array(); + const amrex::Array4 fields = field_data.fields[mfi].array(); // Extract pointers for the k vectors const amrex::Real* const modified_kx_arr = modified_kx_vec[mfi].dataPtr(); -- cgit v1.2.3