diff options
| author |  Erika <3019731+Princesseuh@users.noreply.github.com>
| 2023-01-06 18:01:54 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-01-06 12:01:54 -0500 |
| commit | 2f6745019ac25785032ac3659c2433b6e224f383 (patch) | |
| tree | 4c104600c0450ad6fa1bdb7180bd97a2f7b60971 /.github/workflows | |
| parent | 23937fbbc9fc5647d155dbe418c7c2afd4814c06 (diff) | |
| download | astro-2f6745019ac25785032ac3659c2433b6e224f383.tar.gz astro-2f6745019ac25785032ac3659c2433b6e224f383.tar.zst astro-2f6745019ac25785032ac3659c2433b6e224f383.zip | |
Drop Node 14 in CI for Node 16 and add Node 18 to the matrix (#5768)
* ci(node): Move CI to Node 16 and add Node 18 to the matrix
* fix(netlify): Fix set-cookie not working on Node 18
* fix(netlify): Handle if `set-cookie` is already somehow an array (apparently it can?)
* test(node): Fix `toPromise` to match Astro's
* fix(tests): Use the actual underlying ArrayBuffer instance to create the buffer in toPromise
* chore: changeset
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/benchmark.yml | 18 | ||||
| -rw-r--r-- | .github/workflows/ci.yml | 11 |
2 files changed, 14 insertions, 15 deletions
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 0fd11435c..ccc6d3660 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -16,13 +16,13 @@ jobs: permissions: contents: read outputs: - PR-BENCH-14: ${{ steps.benchmark-pr.outputs.BENCH_RESULT14 }} PR-BENCH-16: ${{ steps.benchmark-pr.outputs.BENCH_RESULT16 }} - MAIN-BENCH-14: ${{ steps.benchmark-main.outputs.BENCH_RESULT14 }} + PR-BENCH-18: ${{ steps.benchmark-pr.outputs.BENCH_RESULT18 }} MAIN-BENCH-16: ${{ steps.benchmark-main.outputs.BENCH_RESULT16 }} + MAIN-BENCH-18: ${{ steps.benchmark-main.outputs.BENCH_RESULT18 }} strategy: matrix: - node-version: [14, 16] + node-version: [16, 18] steps: - uses: actions/checkout@v3 with: @@ -89,12 +89,12 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} pr_number: ${{ github.event.issue.number }} message: | - **Node**: 14 - **PR**: ${{ needs.benchmark.outputs.PR-BENCH-14 }} - **MAIN**: ${{ needs.benchmark.outputs.MAIN-BENCH-14 }} - - --- - **Node**: 16 **PR**: ${{ needs.benchmark.outputs.PR-BENCH-16 }} **MAIN**: ${{ needs.benchmark.outputs.MAIN-BENCH-16 }} + + --- + + **Node**: 18 + **PR**: ${{ needs.benchmark.outputs.PR-BENCH-18 }} + **MAIN**: ${{ needs.benchmark.outputs.MAIN-BENCH-18 }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 86cf1cd5a..0834bd014 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,7 +82,7 @@ jobs: strategy: matrix: OS: [ubuntu-latest] - NODE_VERSION: [14] + NODE_VERSION: [16] fail-fast: true steps: - name: Checkout @@ -111,11 +111,10 @@ jobs: strategy: matrix: OS: [ubuntu-latest, windows-latest] - # TODO: Enable node@18! - NODE_VERSION: [14, 16] + NODE_VERSION: [16, 18] include: - os: macos-latest - NODE_VERSION: 14 + NODE_VERSION: 16 fail-fast: false env: NODE_VERSION: ${{ matrix.NODE_VERSION }} @@ -154,7 +153,7 @@ jobs: strategy: matrix: OS: [ubuntu-latest, windows-latest] - NODE_VERSION: [14] + NODE_VERSION: [16] fail-fast: false env: NODE_VERSION: ${{ matrix.NODE_VERSION }} @@ -188,7 +187,7 @@ jobs: strategy: matrix: OS: [ubuntu-latest, windows-latest] - NODE_VERSION: [14] + NODE_VERSION: [16] env: NODE_VERSION: ${{ matrix.NODE_VERSION }} steps: |