diff options
| author |  Matthew Phillips <matthew@skypack.dev>
| 2023-05-02 13:23:28 -0400 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-05-02 13:23:28 -0400 |
| commit | b6797fc8583f7cb0749e69e72a56fe9fba6f815b (patch) | |
| tree | e18c7002642e603f293ba831d71f20148fd5289d | |
| parent | 72c6bf01fe49b331ca8ad9206a7506b15caf5b8d (diff) | |
| download | astro-b6797fc8583f7cb0749e69e72a56fe9fba6f815b.tar.gz astro-b6797fc8583f7cb0749e69e72a56fe9fba6f815b.tar.zst astro-b6797fc8583f7cb0749e69e72a56fe9fba6f815b.zip | |
Update Solid ecosystem package logic to include packages with peerDep… (#6934)
* Update Solid ecosystem package logic to include packages with peerDep of Solid
* Remove solid as a noExternal
* Update the changeset
| -rw-r--r-- | .changeset/purple-lamps-sleep.md | 5 | ||||
| -rw-r--r-- | packages/integrations/solid/src/index.ts | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/.changeset/purple-lamps-sleep.md b/.changeset/purple-lamps-sleep.md new file mode 100644 index 000000000..9dd063e6a --- /dev/null +++ b/.changeset/purple-lamps-sleep.md @@ -0,0 +1,5 @@ +--- +"@astrojs/solid-js": patch +--- + +Allow Solid ecosystem packages to not need special export map configuration. By default Solid is now treated as an external package in SSR, so any other dependent packages will receive the same instance. diff --git a/packages/integrations/solid/src/index.ts b/packages/integrations/solid/src/index.ts index edf58fdea..8ec9f4d8d 100644 --- a/packages/integrations/solid/src/index.ts +++ b/packages/integrations/solid/src/index.ts @@ -47,7 +47,7 @@ async function getViteConfiguration(isDev: boolean, astroConfig: AstroConfig) { ssr: { target: 'node', external: ['babel-preset-solid', ...solidPkgsConfig.ssr.external], - noExternal: ['solid-js', ...solidPkgsConfig.ssr.noExternal], + noExternal: [...solidPkgsConfig.ssr.noExternal], }, }; } |