diff options
| author |  Gabriel Pereira Woitechen <wtchnm@icloud.com>
| 2024-09-04 10:32:03 -0300 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-09-04 15:32:03 +0200 |
| commit | ca54e3f819fad009ac3c3c8b57a26014a2652a73 (patch) | |
| tree | c2be5044653c3bc27c5bf4d539676e25bb387f6e | |
| parent | 5d7bc70fc369724e2b6a4dad5a34cbe2a29c98f1 (diff) | |
| download | astro-ca54e3f819fad009ac3c3c8b57a26014a2652a73.tar.gz astro-ca54e3f819fad009ac3c3c8b57a26014a2652a73.tar.zst astro-ca54e3f819fad009ac3c3c8b57a26014a2652a73.zip | |
perf(astro/assets): avoid downloading original image when using cache (#11904)
| -rw-r--r-- | .changeset/purple-ears-sneeze.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/assets/build/generate.ts | 17 |
2 files changed, 13 insertions, 9 deletions
diff --git a/.changeset/purple-ears-sneeze.md b/.changeset/purple-ears-sneeze.md new file mode 100644 index 000000000..b79cc2e68 --- /dev/null +++ b/.changeset/purple-ears-sneeze.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +perf(assets): avoid downloading original image when using cache diff --git a/packages/astro/src/assets/build/generate.ts b/packages/astro/src/assets/build/generate.ts index fcc19f4f5..645a0acdc 100644 --- a/packages/astro/src/assets/build/generate.ts +++ b/packages/astro/src/assets/build/generate.ts @@ -98,11 +98,11 @@ export async function generateImagesForPath( env: AssetEnv, queue: PQueue, ) { - const originalImageData = await loadImage(originalFilePath, env); + let originalImage: ImageData; for (const [_, transform] of transformsAndPath.transforms) { await queue - .add(async () => generateImage(originalImageData, transform.finalPath, transform.transform)) + .add(async () => generateImage(transform.finalPath, transform.transform)) .catch((e) => { throw e; }); @@ -128,13 +128,9 @@ export async function generateImagesForPath( } } - async function generateImage( - originalImage: ImageData, - filepath: string, - options: ImageTransform, - ) { + async function generateImage(filepath: string, options: ImageTransform) { const timeStart = performance.now(); - const generationData = await generateImageInternal(originalImage, filepath, options); + const generationData = await generateImageInternal(filepath, options); const timeEnd = performance.now(); const timeChange = getTimeStat(timeStart, timeEnd); @@ -151,7 +147,6 @@ export async function generateImagesForPath( } async function generateImageInternal( - originalImage: ImageData, filepath: string, options: ImageTransform, ): Promise<GenerationData> { @@ -207,6 +202,10 @@ export async function generateImagesForPath( ? (options.src as ImageMetadata).src : (options.src as string); + if (!originalImage) { + originalImage = await loadImage(originalFilePath, env); + } + let resultData: Partial<ImageData> = { data: undefined, expires: originalImage.expires, |