diff options
| author |  Bjorn Lu <bjornlu.dev@gmail.com>
| 2024-01-02 22:14:09 +0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-01-02 23:14:09 +0800 |
| commit | ec71f03cfd9b8195fb21c92dfda0eff63b6ebeed (patch) | |
| tree | 89467a21fe3ded66f71d7e6fc4d2757b3b6a4a34 | |
| parent | f192fc3a35872cb187cf631c62fa5b44f004242b (diff) | |
| download | astro-ec71f03cfd9b8195fb21c92dfda0eff63b6ebeed.tar.gz astro-ec71f03cfd9b8195fb21c92dfda0eff63b6ebeed.tar.zst astro-ec71f03cfd9b8195fb21c92dfda0eff63b6ebeed.zip | |
Remove telemetry for unhandled errors (#9571)
| -rw-r--r-- | .changeset/few-days-relate.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/vite-plugin-astro-server/error.ts | 7 |
2 files changed, 10 insertions, 2 deletions
diff --git a/.changeset/few-days-relate.md b/.changeset/few-days-relate.md new file mode 100644 index 000000000..836e033e3 --- /dev/null +++ b/.changeset/few-days-relate.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Removes telemetry for unhandled errors in the dev server diff --git a/packages/astro/src/vite-plugin-astro-server/error.ts b/packages/astro/src/vite-plugin-astro-server/error.ts index cbab6e7be..7c478fc6e 100644 --- a/packages/astro/src/vite-plugin-astro-server/error.ts +++ b/packages/astro/src/vite-plugin-astro-server/error.ts @@ -3,7 +3,7 @@ import type { AstroConfig } from '../@types/astro.js'; import type DevPipeline from './devPipeline.js'; import { collectErrorMetadata } from '../core/errors/dev/index.js'; -import { createSafeError } from '../core/errors/index.js'; +import { createSafeError, AstroErrorData } from '../core/errors/index.js'; import { formatErrorMessage } from '../core/messages.js'; import { eventError, telemetry } from '../events/index.js'; @@ -24,7 +24,10 @@ export function recordServerError( // Our error should already be complete, but let's try to add a bit more through some guesswork const errorWithMetadata = collectErrorMetadata(err, config.root); - telemetry.record(eventError({ cmd: 'dev', err: errorWithMetadata, isFatal: false })); + // Ignore unhandled rejection errors as they appear A LOT and we cannot record the amount to telemetry + if (errorWithMetadata.name !== AstroErrorData.UnhandledRejection.name) { + telemetry.record(eventError({ cmd: 'dev', err: errorWithMetadata, isFatal: false })); + } pipeline.logger.error( null, |