diff options
| author |  Oliver Speir <115520730+OliverSpeir@users.noreply.github.com>
| 2024-04-11 02:03:56 -0600 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-04-11 09:03:56 +0100 |
| commit | 7e825604ddf90c989537e07939a39dc249343897 (patch) | |
| tree | ee2662feda442b33bb913cbd36115924b8bafe8d | |
| parent | e8683d90f3c1af4f922219ae135513a438b53afc (diff) | |
| download | astro-7e825604ddf90c989537e07939a39dc249343897.tar.gz astro-7e825604ddf90c989537e07939a39dc249343897.tar.zst astro-7e825604ddf90c989537e07939a39dc249343897.zip | |
Update a11y-no-noninteractive-tabindex rule for dev tool bar (#10750)
* fix: a11y-no-noninteractive-tabindex
* add changeset
| -rw-r--r-- | .changeset/few-mails-kiss.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts | 6 |
2 files changed, 10 insertions, 1 deletions
diff --git a/.changeset/few-mails-kiss.md b/.changeset/few-mails-kiss.md new file mode 100644 index 000000000..6bf4fed23 --- /dev/null +++ b/.changeset/few-mails-kiss.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Fixes a false positive for "Invalid `tabindex` on non-interactive element" rule for roleless elements ( `div` and `span` ). diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts index 27da9b011..6d07f36e0 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts @@ -513,7 +513,11 @@ export const a11y: AuditRuleWithSelector[] = [ if (!isInteractive(element)) return false; - if (!interactiveElements.includes(element.localName)) return true; + if ( + !interactiveElements.includes(element.localName) && + !roleless_elements.includes(element.localName) + ) + return true; }, }, { |