diff options
| author |  Caleb Jasik <calebjasik@jasik.xyz>
| 2021-09-14 18:50:00 -0500 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-09-14 16:50:00 -0700 |
| commit | 9cf2df81db9efa6fdaa716a7f7c25323bfeabf9e (patch) | |
| tree | b38cc524cb1fb00e9fd5d4c7d011937d3a75aee8 | |
| parent | 6ac2568ae37d216352fb7e3cfacf182170241074 (diff) | |
| download | astro-9cf2df81db9efa6fdaa716a7f7c25323bfeabf9e.tar.gz astro-9cf2df81db9efa6fdaa716a7f7c25323bfeabf9e.tar.zst astro-9cf2df81db9efa6fdaa716a7f7c25323bfeabf9e.zip | |
Improve stats logging to use `pretty-bytes` so that 20B doesn't get output as 0kB, which is accurate, but confusing (#1329)
| -rw-r--r-- | .changeset/tame-rabbits-behave.md | 5 | ||||
| -rw-r--r-- | packages/astro/package.json | 1 | ||||
| -rw-r--r-- | packages/astro/src/build/stats.ts | 4 | ||||
| -rw-r--r-- | yarn.lock | 5 |
4 files changed, 13 insertions, 2 deletions
diff --git a/.changeset/tame-rabbits-behave.md b/.changeset/tame-rabbits-behave.md new file mode 100644 index 000000000..9f620d6ab --- /dev/null +++ b/.changeset/tame-rabbits-behave.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Improve stats logging to use `pretty-bytes` so that 20B doesn't get output as 0kB, which is accurate, but confusing diff --git a/packages/astro/package.json b/packages/astro/package.json index 702d7ed57..024e55fd8 100644 --- a/packages/astro/package.json +++ b/packages/astro/package.json @@ -85,6 +85,7 @@ "picomatch": "^2.2.3", "postcss": "^8.2.15", "postcss-icss-keyframes": "^0.2.1", + "pretty-bytes": "^5.6.0", "prismjs": "^1.23.0", "resolve": "^1.20.0", "rollup": "^2.43.1", diff --git a/packages/astro/src/build/stats.ts b/packages/astro/src/build/stats.ts index 1e67e0e1a..f5406e16c 100644 --- a/packages/astro/src/build/stats.ts +++ b/packages/astro/src/build/stats.ts @@ -4,6 +4,7 @@ import type { LogOptions } from '../logger'; import { info, table } from '../logger.js'; import { underline, bold } from 'kleur/colors'; import gzipSize from 'gzip-size'; +import prettyBytes from 'pretty-bytes'; interface BundleStats { size: number; @@ -85,8 +86,7 @@ export function logURLStats(logging: LogOptions, urlStats: URLStatsMap) { .get(url) ?.stats.map((s) => s.gzipSize) .reduce((a, b) => a + b, 0) || 0; - const kb = (bytes * 0.001).toFixed(2); - const sizePart = kb + ' kB'; + const sizePart = prettyBytes(bytes, { minimumFractionDigits: 2, maximumFractionDigits: 2 }); log(info, urlPart, sizePart); }); } @@ -8577,6 +8577,11 @@ prettier@^2.2.1, prettier@^2.3.2: resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.3.2.tgz#ef280a05ec253712e486233db5c6f23441e7342d" integrity sha512-lnJzDfJ66zkMy58OL5/NY5zp70S7Nz6KqcKkXYzn2tMVrNxvbqaBpg7H3qHaLxCJ5lNMsGuM8+ohS7cZrthdLQ== +pretty-bytes@^5.6.0: + version "5.6.0" + resolved "https://registry.yarnpkg.com/pretty-bytes/-/pretty-bytes-5.6.0.tgz#356256f643804773c82f64723fe78c92c62beaeb" + integrity sha512-FFw039TmrBqFK8ma/7OL3sDz/VytdtJr044/QUJtH0wK9lb9jLq9tJyIxUwtQJHwar2BqtiA4iCWSwo9JLkzFg== + pretty-format@^3.8.0: version "3.8.0" resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-3.8.0.tgz#bfbed56d5e9a776645f4b1ff7aa1a3ac4fa3c385" |