diff options
| author |  Matt Kane <m@mk.gg>
| 2024-12-10 20:00:58 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-12-10 20:00:58 +0000 |
| commit | f6c4214042c68de137a69aa15dea81ed9cbc822a (patch) | |
| tree | d32f9fa148a51d3184857fc996444032f0a0c7a4 | |
| parent | 316959355c3d59723ecb3e0f417becf1f03ddd74 (diff) | |
| download | astro-f6c4214042c68de137a69aa15dea81ed9cbc822a.tar.gz astro-f6c4214042c68de137a69aa15dea81ed9cbc822a.tar.zst astro-f6c4214042c68de137a69aa15dea81ed9cbc822a.zip | |
fix: correctly check isOnline with port (#12706)
| -rw-r--r-- | .changeset/wild-ducks-decide.md | 5 | ||||
| -rw-r--r-- | packages/upgrade/src/actions/verify.ts | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/.changeset/wild-ducks-decide.md b/.changeset/wild-ducks-decide.md new file mode 100644 index 000000000..8a6f85be7 --- /dev/null +++ b/.changeset/wild-ducks-decide.md @@ -0,0 +1,5 @@ +--- +'@astrojs/upgrade': patch +--- + +Fixes a bug that caused registry URLs that specify a port to be incorrectly detected as offline. diff --git a/packages/upgrade/src/actions/verify.ts b/packages/upgrade/src/actions/verify.ts index 384df5134..3b7c15a9e 100644 --- a/packages/upgrade/src/actions/verify.ts +++ b/packages/upgrade/src/actions/verify.ts @@ -43,8 +43,8 @@ export async function verify( } function isOnline(registry: string): Promise<boolean> { - const { host } = new URL(registry); - return dns.lookup(host).then( + const { hostname } = new URL(registry); + return dns.lookup(hostname).then( () => true, () => false, ); |