diff options
| author |  Ben Holmes <hey@bholmes.dev>
| 2023-01-03 09:45:38 -0500 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-01-03 09:45:38 -0500 |
| commit | 3aa3e00a63b63ae443f824f11cffde2a194ea4bf (patch) | |
| tree | 8d85f7d698a020e85b32feefc89bfa1e95c58fd4 | |
| parent | bf210f7841711439f7db6c2b1f369e54a70b03d3 (diff) | |
| download | astro-3aa3e00a63b63ae443f824f11cffde2a194ea4bf.tar.gz astro-3aa3e00a63b63ae443f824f11cffde2a194ea4bf.tar.zst astro-3aa3e00a63b63ae443f824f11cffde2a194ea4bf.zip | |
[Content Collections] Fix `import.meta.env.DEV` always set to `true` (#5700)
* fix: reset NODE_ENV on content config read
* fix: move nodeEnv setter above createServer
* chore: changeset
| -rw-r--r-- | .changeset/yellow-gifts-complain.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/content/utils.ts | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/.changeset/yellow-gifts-complain.md b/.changeset/yellow-gifts-complain.md new file mode 100644 index 000000000..f220d26c8 --- /dev/null +++ b/.changeset/yellow-gifts-complain.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Fix `import.meta.env.DEV` always being set to `true` when using Content Collections diff --git a/packages/astro/src/content/utils.ts b/packages/astro/src/content/utils.ts index 9017072ed..a3e7d4f99 100644 --- a/packages/astro/src/content/utils.ts +++ b/packages/astro/src/content/utils.ts @@ -190,6 +190,7 @@ export async function loadContentConfig({ settings: AstroSettings; }): Promise<ContentConfig | Error> { const contentPaths = getContentPaths({ srcDir: settings.config.srcDir }); + const nodeEnv = process.env.NODE_ENV; const tempConfigServer: ViteDevServer = await createServer({ root: fileURLToPath(settings.config.root), server: { middlewareMode: true, hmr: false }, @@ -206,6 +207,9 @@ export async function loadContentConfig({ return new NotFoundError('Failed to resolve content config.'); } finally { await tempConfigServer.close(); + // Reset NODE_ENV to initial value + // Vite's `createServer()` sets NODE_ENV to 'development'! + process.env.NODE_ENV = nodeEnv; } const config = contentConfigParser.safeParse(unparsedConfig); if (config.success) { |