diff options
| author |  Ari Gibson <hi@arimgibson.com>
| 2022-07-23 17:27:35 -0600 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-07-23 18:27:35 -0500 |
| commit | beddf073b5222b92da172475f5b8a578bffa73a0 (patch) | |
| tree | df881439281a12a9421901246b15bfdb4e298397 | |
| parent | 8c0818182208c85032aabf39c4fb71472fa28126 (diff) | |
| download | astro-beddf073b5222b92da172475f5b8a578bffa73a0.tar.gz astro-beddf073b5222b92da172475f5b8a578bffa73a0.tar.zst astro-beddf073b5222b92da172475f5b8a578bffa73a0.zip | |
Fix: (patching old PR) Check node version and find acceptable host accordingly (#4032)
* fix: check node version and find acceptable host accordingly
* Update for Node v18.4+
* Removed unrelated changesets
* Revert "Removed unrelated changesets"
This reverts commit e77ffc0fed79568a677d497058d3bbca8faeab7c.
* chore: remove duplicate changeset
Co-authored-by: Nate Moore <nate@astro.build>
| -rw-r--r-- | .changeset/strange-needles-hide.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/core/messages.ts | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/.changeset/strange-needles-hide.md b/.changeset/strange-needles-hide.md new file mode 100644 index 000000000..bcfab6701 --- /dev/null +++ b/.changeset/strange-needles-hide.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Fix: find a hosting network differently based on Node version -- adjusted for Node v18.4+ diff --git a/packages/astro/src/core/messages.ts b/packages/astro/src/core/messages.ts index aa29723c6..7676a5b7c 100644 --- a/packages/astro/src/core/messages.ts +++ b/packages/astro/src/core/messages.ts @@ -83,12 +83,13 @@ export function devStart({ if (networkLogging === 'host-to-expose') { network = `${networkPrefix}${dim('use --host to expose')}`; } else if (networkLogging === 'visible') { + const nodeVersion = Number(process.version.substring(1, process.version.indexOf(".", 5))); const ipv4Networks = Object.values(os.networkInterfaces()) .flatMap((networkInterface) => networkInterface ?? []) .filter( (networkInterface) => networkInterface?.address && - networkInterface?.family === (Number(process.version.substring(1, 5)) < 18.1 ? 'IPv4' : 4) + networkInterface?.family === ((nodeVersion < 18 || nodeVersion >= 18.4) ? 'IPv4' : 4) ); for (let { address } of ipv4Networks) { if (address.includes('127.0.0.1')) { |