diff options
author | 2023-02-09 13:12:15 -0600 | |
---|---|---|
committer | 2023-02-09 13:12:15 -0600 | |
commit | c75d319ee6b657402b902b1b46b9d3f2d0e5370b (patch) | |
tree | e8a9fcdc35e16777639598681bca5b0e451b4768 | |
parent | 11e1fa9883ff94e81865e0db631efa1a2b18688c (diff) | |
download | astro-c75d319ee6b657402b902b1b46b9d3f2d0e5370b.tar.gz astro-c75d319ee6b657402b902b1b46b9d3f2d0e5370b.tar.zst astro-c75d319ee6b657402b902b1b46b9d3f2d0e5370b.zip |
Fix types for TableHTMLAttributes (#6197)
* Fix types for TableHTMLAttributes
- Add 'string' type to 'border' attribute
- Add 'false | true' to 'frame' attribute
Thanks Princesseuh for helping
* Create sixty-scissors-refuse.md
* Make changeset more descriptive
* Fix previous changset
---------
Co-authored-by: BryceRussell <19967622+BryceRussell@users.noreply.github.com>
-rw-r--r-- | .changeset/sixty-scissors-refuse.md | 6 | ||||
-rw-r--r-- | packages/astro/astro-jsx.d.ts | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/.changeset/sixty-scissors-refuse.md b/.changeset/sixty-scissors-refuse.md new file mode 100644 index 000000000..71452bfae --- /dev/null +++ b/.changeset/sixty-scissors-refuse.md @@ -0,0 +1,6 @@ +--- +'astro': patch +--- + +Fix `border` and `frame` attribute types on `TableHTMLAttributes` interface + diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 38e924523..fc38e5c1b 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -936,10 +936,10 @@ declare namespace astroHTML.JSX { interface TableHTMLAttributes extends HTMLAttributes { align?: 'left' | 'center' | 'right' | undefined | null; bgcolor?: string | undefined | null; - border?: number | undefined | null; + border?: string | number | undefined | null; cellpadding?: number | string | undefined | null; cellspacing?: number | string | undefined | null; - frame?: boolean | undefined | null; + frame?: boolean | 'false' | 'true' | undefined | null; rules?: 'none' | 'groups' | 'rows' | 'columns' | 'all' | undefined | null; summary?: string | undefined | null; width?: number | string | undefined | null; |