summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Erika <3019731+Princesseuh@users.noreply.github.com> 2022-08-23 11:39:02 -0300
committerGravatar GitHub <noreply@github.com> 2022-08-23 11:39:02 -0300
commitca0c7e8b836b1be2db6a77698c9535a34ada8fe6 (patch)
treeca1373961a2cf9ac3d26bde496300e9df35c9503
parentbaa2ddd0103c269c862258520020395135e823ec (diff)
downloadastro-ca0c7e8b836b1be2db6a77698c9535a34ada8fe6.tar.gz
astro-ca0c7e8b836b1be2db6a77698c9535a34ada8fe6.tar.zst
astro-ca0c7e8b836b1be2db6a77698c9535a34ada8fe6.zip
Allow string as a valid value for the target attribute (#4441)
-rw-r--r--.changeset/nice-mice-teach.md5
-rw-r--r--packages/astro/astro-jsx.d.ts4
2 files changed, 7 insertions, 2 deletions
diff --git a/.changeset/nice-mice-teach.md b/.changeset/nice-mice-teach.md
new file mode 100644
index 000000000..1d0d916a9
--- /dev/null
+++ b/.changeset/nice-mice-teach.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Allow arbitrary strings on the target attribute
diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts
index 226391a82..bdf6b6aa2 100644
--- a/packages/astro/astro-jsx.d.ts
+++ b/packages/astro/astro-jsx.d.ts
@@ -548,7 +548,7 @@ declare namespace astroHTML.JSX {
| 'strict-origin-when-cross-origin'
| 'unsafe-url';
- type HTMLAttributeAnchorTarget = '_self' | '_blank' | '_parent' | '_top';
+ type HTMLAttributeAnchorTarget = '_self' | '_blank' | '_parent' | '_top' | (string & {});
interface AnchorHTMLAttributes extends HTMLAttributes {
download?: string | boolean | undefined | null;
@@ -756,7 +756,7 @@ declare namespace astroHTML.JSX {
size?: number | string | undefined | null;
src?: string | undefined | null;
step?: number | string | undefined | null;
- type?: HTMLInputTypeAttribute | string | undefined | null;
+ type?: HTMLInputTypeAttribute | undefined | null;
value?: string | string[] | number | undefined | null;
width?: number | string | undefined | null;
}