summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Tony Sullivan <tony.f.sullivan@outlook.com> 2022-06-16 22:09:47 +0000
committerGravatar GitHub <noreply@github.com> 2022-06-16 22:09:47 +0000
commite02097d0b964d719f04fa2fe3d4995b5bee4fa48 (patch)
tree6322da8f6408cc93553160818907ef5f5585ca1c
parent971674787988b5a0e868c0fe1c9518b593269f7a (diff)
downloadastro-e02097d0b964d719f04fa2fe3d4995b5bee4fa48.tar.gz
astro-e02097d0b964d719f04fa2fe3d4995b5bee4fa48.tar.zst
astro-e02097d0b964d719f04fa2fe3d4995b5bee4fa48.zip
Investiging a flaky error test (#3613)
* restarting dev server between each error test * re-enabling the test on Linux CI * trying separate describe() suites per error test * narrowed the issue down, disabling for more investigation * not: removing unrelated whitespace change
-rw-r--r--packages/astro/test/errors.test.js20
1 files changed, 13 insertions, 7 deletions
diff --git a/packages/astro/test/errors.test.js b/packages/astro/test/errors.test.js
index 78edcc4da..9dd158d22 100644
--- a/packages/astro/test/errors.test.js
+++ b/packages/astro/test/errors.test.js
@@ -5,10 +5,6 @@ import * as cheerio from 'cheerio';
describe('Error display', () => {
if (isWindows) return;
- // TODO: Ubuntu CI runs hit a reliability problem with more than one test in this suite.
- // Re-enable this suite once that issue is tracked down.
- if (isLinux) return;
-
/** @type {import('./test-utils').Fixture} */
let fixture;
@@ -18,14 +14,24 @@ describe('Error display', () => {
});
});
- describe('Astro', async () => {
+ /**
+ * TODO: Track down reliability issue
+ *
+ * After fixing a syntax error on one page, the dev server hangs on the hmr.js request.
+ * This is specific to a project that has other framework component errors,
+ * in this case the fixture has multiple broken pages and components.
+ *
+ * The issue could be internal to vite, the hmr.js request triggers connect:dispatcher
+ * events but vite:load is never actually called.
+ */
+ describe.skip('Astro template syntax', async () => {
let devServer;
- before(async () => {
+ beforeEach(async () => {
devServer = await fixture.startDevServer();
});
- after(async () => {
+ afterEach(async () => {
await devServer.stop();
});