diff options
| author |  Rishi Raj Jain <rishi18304@iiitd.ac.in>
| 2022-09-23 17:38:57 +0530 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-09-23 08:08:57 -0400 |
| commit | edb7bead6e42b463dce0f6837ea78ae733eab88b (patch) | |
| tree | 733e667b06d3b091b273873bc02b71592b35a420 | |
| parent | ee5fdeffddfee32a0d7708bbf6b64cee50e82aa7 (diff) | |
| download | astro-edb7bead6e42b463dce0f6837ea78ae733eab88b.tar.gz astro-edb7bead6e42b463dce0f6837ea78ae733eab88b.tar.zst astro-edb7bead6e42b463dce0f6837ea78ae733eab88b.zip | |
fix: Can't overwrite vite's MODE environment variable (#4850)
* Add flags to the build options
* replace mode: 'production' as fallback
* Update mode support
* Add changeset
| -rw-r--r-- | .changeset/short-ravens-marry.md | 5 | ||||
| -rw-r--r-- | packages/astro/src/cli/index.ts | 2 | ||||
| -rw-r--r-- | packages/astro/src/core/build/static-build.ts | 4 |
3 files changed, 8 insertions, 3 deletions
diff --git a/.changeset/short-ravens-marry.md b/.changeset/short-ravens-marry.md new file mode 100644 index 000000000..c8aed9bcc --- /dev/null +++ b/.changeset/short-ravens-marry.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +add support for changing mode via CLI diff --git a/packages/astro/src/cli/index.ts b/packages/astro/src/cli/index.ts index 8263cc19b..93e589396 100644 --- a/packages/astro/src/cli/index.ts +++ b/packages/astro/src/cli/index.ts @@ -239,7 +239,7 @@ async function runCommand(cmd: string, flags: yargs.Arguments) { } case 'build': { - return await build(settings, { logging, telemetry }); + return await build(settings, { ...flags, logging, telemetry }); } case 'check': { diff --git a/packages/astro/src/core/build/static-build.ts b/packages/astro/src/core/build/static-build.ts index 58d3c6c56..40237659f 100644 --- a/packages/astro/src/core/build/static-build.ts +++ b/packages/astro/src/core/build/static-build.ts @@ -115,8 +115,8 @@ async function ssrBuild(opts: StaticBuildOptions, internals: BuildInternals, inp const viteBuildConfig: ViteConfigWithSSR = { ...viteConfig, + mode: viteConfig.mode || 'production', logLevel: opts.viteConfig.logLevel ?? 'error', - mode: 'production', build: { target: 'esnext', ...viteConfig.build, @@ -193,8 +193,8 @@ async function clientBuild( const viteBuildConfig = { ...viteConfig, + mode: viteConfig.mode || 'production', logLevel: 'info', - mode: 'production', build: { target: 'esnext', ...viteConfig.build, |