diff options
| author |  Happydev <81974850+MoustaphaDev@users.noreply.github.com>
| 2022-10-28 02:05:18 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-10-27 21:05:18 -0500 |
| commit | 0b12414315fa81ded96587779c63c74400466078 (patch) | |
| tree | f3dfb0c6f89efa3087f4a98e16754e479cc68696 | |
| parent | 25a6360a60d5029b861725a58541f7fad93ab434 (diff) | |
| download | astro-0b12414315fa81ded96587779c63c74400466078.tar.gz astro-0b12414315fa81ded96587779c63c74400466078.tar.zst astro-0b12414315fa81ded96587779c63c74400466078.zip | |
remove unnecessary `ReactDOM.renderToString` operation (#5218)
* remove useless `ReactDOM.renderToString` operation
* chore: add changeset
| -rw-r--r-- | .changeset/tasty-rules-sleep.md | 5 | ||||
| -rw-r--r-- | packages/integrations/react/server.js | 1 |
2 files changed, 5 insertions, 1 deletions
diff --git a/.changeset/tasty-rules-sleep.md b/.changeset/tasty-rules-sleep.md new file mode 100644 index 000000000..0bc19c626 --- /dev/null +++ b/.changeset/tasty-rules-sleep.md @@ -0,0 +1,5 @@ +--- +'@astrojs/react': patch +--- + +remove unnecessary `ReactDOM.renderToString` operation diff --git a/packages/integrations/react/server.js b/packages/integrations/react/server.js index 6dd289c99..1ebd044cf 100644 --- a/packages/integrations/react/server.js +++ b/packages/integrations/react/server.js @@ -75,7 +75,6 @@ async function renderToStaticMarkup(Component, props, { default: children, ...sl const vnode = React.createElement(Component, newProps); let html; if (metadata && metadata.hydrate) { - html = ReactDOM.renderToString(vnode); if ('renderToReadableStream' in ReactDOM) { html = await renderToReadableStreamAsync(vnode); } else { |