summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Arsh <69170106+lilnasy@users.noreply.github.com> 2023-09-20 13:57:46 +0530
committerGravatar GitHub <noreply@github.com> 2023-09-20 10:27:46 +0200
commit2e1d5f8739552c3428aa7cbb82811ed2b9b24fdb (patch)
treea55c0b024d063d3101dbba8e6096884bb395ea67
parent1f1c47d909fc96301b51a165fae4acdf43c276fc (diff)
downloadastro-2e1d5f8739552c3428aa7cbb82811ed2b9b24fdb.tar.gz
astro-2e1d5f8739552c3428aa7cbb82811ed2b9b24fdb.tar.zst
astro-2e1d5f8739552c3428aa7cbb82811ed2b9b24fdb.zip
fix(node): report render error to the terminal (#8599)
-rw-r--r--.changeset/curly-icons-watch.md5
-rw-r--r--packages/integrations/node/src/nodeMiddleware.ts3
2 files changed, 8 insertions, 0 deletions
diff --git a/.changeset/curly-icons-watch.md b/.changeset/curly-icons-watch.md
new file mode 100644
index 000000000..8c2561904
--- /dev/null
+++ b/.changeset/curly-icons-watch.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/node': patch
+---
+
+The node adapter now logs uncaught errors encountered during rendering a page.
diff --git a/packages/integrations/node/src/nodeMiddleware.ts b/packages/integrations/node/src/nodeMiddleware.ts
index 32b8020dc..eaab0790c 100644
--- a/packages/integrations/node/src/nodeMiddleware.ts
+++ b/packages/integrations/node/src/nodeMiddleware.ts
@@ -51,6 +51,9 @@ export default function (app: NodeApp, mode: Options['mode']) {
await writeWebResponse(app, res, response);
}
} catch (err: unknown) {
+ const logger = app.getAdapterLogger()
+ logger.error(`Could not render ${req.url}`)
+ console.error(err)
if (!res.headersSent) {
res.writeHead(500, `Server error`);
res.end();