summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Bjorn Lu <bjornlu.dev@gmail.com> 2023-05-26 16:59:51 +0800
committerGravatar GitHub <noreply@github.com> 2023-05-26 16:59:51 +0800
commit52af9ad18840ffa4e2996386c82cbe34d9fd076a (patch)
tree39fb5fc9d6cfee3e5c2b8d24525252e67c905df2
parent184870e2e25607518a412f29be6b21ac8995e689 (diff)
downloadastro-52af9ad18840ffa4e2996386c82cbe34d9fd076a.tar.gz
astro-52af9ad18840ffa4e2996386c82cbe34d9fd076a.tar.zst
astro-52af9ad18840ffa4e2996386c82cbe34d9fd076a.zip
Add error message if `Astro.glob` is called outside (#7204)
-rw-r--r--.changeset/moody-coats-develop.md5
-rw-r--r--packages/astro/src/runtime/server/astro-global.ts5
-rw-r--r--packages/astro/test/units/runtime/astro-global.test.js13
3 files changed, 23 insertions, 0 deletions
diff --git a/.changeset/moody-coats-develop.md b/.changeset/moody-coats-develop.md
new file mode 100644
index 000000000..20c12708c
--- /dev/null
+++ b/.changeset/moody-coats-develop.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Add error message if `Astro.glob` is called outside of an Astro file
diff --git a/packages/astro/src/runtime/server/astro-global.ts b/packages/astro/src/runtime/server/astro-global.ts
index 7ed511322..70c4e565b 100644
--- a/packages/astro/src/runtime/server/astro-global.ts
+++ b/packages/astro/src/runtime/server/astro-global.ts
@@ -4,6 +4,11 @@ import { ASTRO_VERSION } from '../../core/constants.js';
/** Create the Astro.glob() runtime function. */
function createAstroGlobFn() {
const globHandler = (importMetaGlobResult: Record<string, any>, globValue: () => any) => {
+ if (typeof importMetaGlobResult === 'string') {
+ throw new Error(
+ 'Astro.glob() does not work outside of an Astro file. Use `import.meta.glob()` instead.'
+ );
+ }
let allEntries = [...Object.values(importMetaGlobResult)];
if (allEntries.length === 0) {
throw new Error(`Astro.glob(${JSON.stringify(globValue())}) - no matches found.`);
diff --git a/packages/astro/test/units/runtime/astro-global.test.js b/packages/astro/test/units/runtime/astro-global.test.js
new file mode 100644
index 000000000..975651b76
--- /dev/null
+++ b/packages/astro/test/units/runtime/astro-global.test.js
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { createAstro } from '../../../dist/runtime/server/index.js';
+
+describe('astro global', () => {
+ it('Glob should error if passed incorrect value', async () => {
+ const Astro = createAstro(undefined);
+ expect(() => {
+ Astro.glob('./**/*.md');
+ }).to.throw(
+ 'Astro.glob() does not work outside of an Astro file. Use `import.meta.glob()` instead.'
+ );
+ });
+});