diff options
| author |  Juan MartÃn Seery <me@juanm04.com>
| 2022-05-16 15:34:46 -0300 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-05-16 13:34:46 -0500 |
| commit | 9d01f93b1c7db5d4afc4041e6ee73fb52f24d2d1 (patch) | |
| tree | c327532b6d22deb43f5e9cded427c1f44a64af40 | |
| parent | 9dd16bace5c9ee337461baaacb0fa72b6ebdc485 (diff) | |
| download | astro-9d01f93b1c7db5d4afc4041e6ee73fb52f24d2d1.tar.gz astro-9d01f93b1c7db5d4afc4041e6ee73fb52f24d2d1.tar.zst astro-9d01f93b1c7db5d4afc4041e6ee73fb52f24d2d1.zip | |
feat(vercel): remove `nodeVersion` (#3368)
* Remove `nodeVersion`
* Changeset
| -rw-r--r-- | .changeset/silver-toes-retire.md | 5 | ||||
| -rw-r--r-- | packages/integrations/vercel/README.md | 13 | ||||
| -rw-r--r-- | packages/integrations/vercel/src/serverless/adapter.ts | 14 |
3 files changed, 13 insertions, 19 deletions
diff --git a/.changeset/silver-toes-retire.md b/.changeset/silver-toes-retire.md new file mode 100644 index 000000000..326244211 --- /dev/null +++ b/.changeset/silver-toes-retire.md @@ -0,0 +1,5 @@ +--- +'@astrojs/vercel': patch +--- + +Remove `nodeVersion` option for `serverless` target. Now it is inferred from Vercel diff --git a/packages/integrations/vercel/README.md b/packages/integrations/vercel/README.md index a30617b67..3545774cf 100644 --- a/packages/integrations/vercel/README.md +++ b/packages/integrations/vercel/README.md @@ -59,19 +59,6 @@ import vercel from '@astrojs/vercel/serverless'; import vercel from '@astrojs/vercel/static'; ``` -### Node.js version - -When deploying to `serverless` you can choose what version of Node.js you want to target: `12.x`, `14.x` or `16.x` (default). - -```js -import { defineConfig } from 'astro/config'; -import vercel from '@astrojs/vercel/serverless'; - -export default defineConfig({ - adapter: vercel({ nodeVersion: '14.x' }) -}); -``` - ## Limitations **A few known complex packages (example: [puppeteer](https://github.com/puppeteer/puppeteer)) do not support bundling and therefore will not work properly with this adapter.** By default, Vercel doesn't include npm installed files & packages from your project's `./node_modules` folder. To address this, the `@astrojs/vercel` adapter automatically bundles your final build output using `esbuild`. diff --git a/packages/integrations/vercel/src/serverless/adapter.ts b/packages/integrations/vercel/src/serverless/adapter.ts index babda1f84..a554fe175 100644 --- a/packages/integrations/vercel/src/serverless/adapter.ts +++ b/packages/integrations/vercel/src/serverless/adapter.ts @@ -14,11 +14,7 @@ function getAdapter(): AstroAdapter { }; } -export interface Options { - nodeVersion?: '12.x' | '14.x' | '16.x'; -} - -export default function vercelEdge({ nodeVersion = '16.x' }: Options = {}): AstroIntegration { +export default function vercelEdge(): AstroIntegration { let _config: AstroConfig; let functionFolder: URL; let serverEntry: string; @@ -57,7 +53,7 @@ export default function vercelEdge({ nodeVersion = '16.x' }: Options = {}): Astr // Serverless function config // https://vercel.com/docs/build-output-api/v3#vercel-primitives/serverless-functions/configuration await writeJson(new URL(`./.vc-config.json`, functionFolder), { - runtime: `nodejs${nodeVersion}`, + runtime: getRuntime(), handler: serverEntry, launcherType: 'Nodejs', }); @@ -76,3 +72,9 @@ export default function vercelEdge({ nodeVersion = '16.x' }: Options = {}): Astr }, }; } + +function getRuntime() { + const version = process.version.slice(1); // 'v16.5.0' --> '16.5.0' + const major = version.split('.')[0]; // '16.5.0' --> '16' + return `nodejs${major}.x`; +} |