summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Bjorn Lu <bjornlu.dev@gmail.com> 2024-01-04 19:16:53 +0800
committerGravatar GitHub <noreply@github.com> 2024-01-04 11:16:53 +0000
commit3b4e629ac8c2fdb4b491bf01abc7794e2e100173 (patch)
treeb2818dfc3dcd97d6804e493a886eb0c2a79311ff
parent82bad5d6205672ed3f6a49d4de53d3a68367433e (diff)
downloadastro-3b4e629ac8c2fdb4b491bf01abc7794e2e100173.tar.gz
astro-3b4e629ac8c2fdb4b491bf01abc7794e2e100173.tar.zst
astro-3b4e629ac8c2fdb4b491bf01abc7794e2e100173.zip
Improve astro add deps error reporting (#9593)
-rw-r--r--.changeset/afraid-socks-rescue.md5
-rw-r--r--packages/astro/src/cli/add/index.ts5
2 files changed, 8 insertions, 2 deletions
diff --git a/.changeset/afraid-socks-rescue.md b/.changeset/afraid-socks-rescue.md
new file mode 100644
index 000000000..b5a9c587e
--- /dev/null
+++ b/.changeset/afraid-socks-rescue.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Improves `astro add` error reporting when the dependencies fail to install
diff --git a/packages/astro/src/cli/add/index.ts b/packages/astro/src/cli/add/index.ts
index 1240e67de..74a4f7362 100644
--- a/packages/astro/src/cli/add/index.ts
+++ b/packages/astro/src/cli/add/index.ts
@@ -732,11 +732,12 @@ async function tryToInstallIntegrations({
);
spinner.succeed();
return UpdateResult.updated;
- } catch (err) {
+ } catch (err: any) {
spinner.fail();
logger.debug('add', 'Error installing dependencies', err);
+ // NOTE: `err.stdout` can be an empty string, so log the full error instead for a more helpful log
// eslint-disable-next-line no-console
- console.error('\n', (err as any).stdout, '\n');
+ console.error('\n', err.stdout || err.message, '\n');
return UpdateResult.failure;
}
} else {