diff options
| author |  Arpan Patel <ap.patel1893@gmail.com>
| 2024-12-02 08:38:05 -0600 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-12-02 22:38:05 +0800 |
| commit | b139390deb738f96759cb787fe9e784be71f2134 (patch) | |
| tree | 60ab0518cb7306c22a8dfc8d762835ccd1fdb803 | |
| parent | fa07002352147d45da193f28fd6e02d2d42dc67a (diff) | |
| download | astro-b139390deb738f96759cb787fe9e784be71f2134.tar.gz astro-b139390deb738f96759cb787fe9e784be71f2134.tar.zst astro-b139390deb738f96759cb787fe9e784be71f2134.zip | |
fix(upgrade): enhance version comparison by normalizing `targetVersion` (#12577)
| -rw-r--r-- | .changeset/dirty-bees-repair.md | 5 | ||||
| -rw-r--r-- | packages/upgrade/src/actions/install.ts | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/.changeset/dirty-bees-repair.md b/.changeset/dirty-bees-repair.md new file mode 100644 index 000000000..98fc2f714 --- /dev/null +++ b/.changeset/dirty-bees-repair.md @@ -0,0 +1,5 @@ +--- +'@astrojs/upgrade': patch +--- + +Fixes an issue where `@astrojs/upgrade` announces integration updates for already up to date packages diff --git a/packages/upgrade/src/actions/install.ts b/packages/upgrade/src/actions/install.ts index f031729e4..6e593b976 100644 --- a/packages/upgrade/src/actions/install.ts +++ b/packages/upgrade/src/actions/install.ts @@ -90,8 +90,8 @@ function filterPackages(ctx: Pick<Context, 'packages'>) { const devDependencies: PackageInfo[] = []; for (const packageInfo of ctx.packages) { const { currentVersion, targetVersion, isDevDependency } = packageInfo; - // Remove prefix from `currentVersion` before comparing - if (currentVersion.replace(/^\D+/, '') === targetVersion) { + // Remove prefix from version before comparing + if (currentVersion.replace(/^\D+/, '') === targetVersion.replace(/^\D+/, '')) { current.push(packageInfo); } else { const arr = isDevDependency ? devDependencies : dependencies; |