aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Anshul Gupta <ansg191@anshulg.com> 2025-06-06 10:17:09 -0700
committerGravatar Anshul Gupta <ansg191@anshulg.com> 2025-06-06 10:59:05 -0700
commite667a3b6f0ba56c9a7edeb22f9ae479434e20b2d (patch)
tree3a8d69c45f2b9d32a027314e65140a828881b672
parenta8e1c0a7402940e0fc5beef669522b315052df1b (diff)
downloadastro-e667a3b6f0ba56c9a7edeb22f9ae479434e20b2d.tar.gz
astro-e667a3b6f0ba56c9a7edeb22f9ae479434e20b2d.tar.zst
astro-e667a3b6f0ba56c9a7edeb22f9ae479434e20b2d.zip
fix: server island fallback not being deleted
-rw-r--r--.changeset/silly-peas-smash.md5
-rw-r--r--packages/astro/src/runtime/server/render/server-islands.ts4
2 files changed, 7 insertions, 2 deletions
diff --git a/.changeset/silly-peas-smash.md b/.changeset/silly-peas-smash.md
new file mode 100644
index 000000000..a123369c7
--- /dev/null
+++ b/.changeset/silly-peas-smash.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+fix fallback not being removed when server island is rendered
diff --git a/packages/astro/src/runtime/server/render/server-islands.ts b/packages/astro/src/runtime/server/render/server-islands.ts
index 8e830718e..cf406caf8 100644
--- a/packages/astro/src/runtime/server/render/server-islands.ts
+++ b/packages/astro/src/runtime/server/render/server-islands.ts
@@ -149,14 +149,14 @@ let response = await fetch('${serverIslandUrl}', {
return createThinHead();
}
async render(destination: RenderDestination) {
+ destination.write(createRenderInstruction({ type: 'server-island-runtime' }));
+ destination.write('<!--[if astro]>server-island-start<![endif]-->');
// Render the slots
for (const name in this.slots) {
if (name === 'fallback') {
await renderChild(destination, this.slots.fallback(this.result));
}
}
- destination.write(createRenderInstruction({ type: 'server-island-runtime' }));
- destination.write('<!--[if astro]>server-island-start<![endif]-->');
destination.write(
`<script type="module" data-astro-rerun data-island-id="${this.hostId}">${this.islandContent}</script>`,
);