diff options
author | 2022-08-04 14:16:51 -0400 | |
---|---|---|
committer | 2022-08-04 14:16:51 -0400 | |
commit | f591150512903014461e4fa1be3bc53bd261af2f (patch) | |
tree | dfdad8d11b3379cc47618398281ebca6e1be91bc /examples/framework-multiple/src/components | |
parent | 32580d4fdc6ba8bb9a7e39e0b2c001ab29b3b940 (diff) | |
download | astro-f591150512903014461e4fa1be3bc53bd261af2f.tar.gz astro-f591150512903014461e4fa1be3bc53bd261af2f.tar.zst astro-f591150512903014461e4fa1be3bc53bd261af2f.zip |
Audit examples templates (#3940)
* basics, framework-alpine, framework-solid, delete unused examples
* framework-multiple
* Remove non-standard file extensions, add missing .vscode folders
* Remove robots.txt
* Remove blog-multiple-authors
* Rewrite components comments to be consistent
* Update lockfile
* Remove unnecessary usage of SCSS in subpath example
* Fix props weirdness in portfolio example
* Remove Lit from `framework-multiple` for now
* Misc fixes
* Update lockfile
* I'm in lockfile hell, send help
Diffstat (limited to 'examples/framework-multiple/src/components')
-rw-r--r-- | examples/framework-multiple/src/components/A.astro | 3 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/B.astro | 3 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/LitCounter.js | 33 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/PreactCounter.tsx | 4 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/PreactSFC.tsx | 10 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/ReactCounter.tsx (renamed from examples/framework-multiple/src/components/ReactCounter.jsx) | 2 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/SolidCounter.tsx | 4 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/SvelteCounter.svelte | 21 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/VueCounter.vue | 8 | ||||
-rw-r--r-- | examples/framework-multiple/src/components/index.ts | 2 |
10 files changed, 25 insertions, 65 deletions
diff --git a/examples/framework-multiple/src/components/A.astro b/examples/framework-multiple/src/components/A.astro deleted file mode 100644 index 2b7bd482a..000000000 --- a/examples/framework-multiple/src/components/A.astro +++ /dev/null @@ -1,3 +0,0 @@ -<div class="children"> - <h1>Hello Astro (A)</h1> -</div> diff --git a/examples/framework-multiple/src/components/B.astro b/examples/framework-multiple/src/components/B.astro deleted file mode 100644 index 3640fe831..000000000 --- a/examples/framework-multiple/src/components/B.astro +++ /dev/null @@ -1,3 +0,0 @@ -<div class="children"> - <h1>Hello Astro (B)</h1> -</div> diff --git a/examples/framework-multiple/src/components/LitCounter.js b/examples/framework-multiple/src/components/LitCounter.js deleted file mode 100644 index 883a7581d..000000000 --- a/examples/framework-multiple/src/components/LitCounter.js +++ /dev/null @@ -1,33 +0,0 @@ -import { LitElement, html } from 'lit'; - -export const tagName = 'my-counter'; - -class Counter extends LitElement { - static get properties() { - return { - count: { - type: Number, - }, - }; - } - - constructor() { - super(); - this.count = 0; - } - - increment() { - this.count++; - } - - render() { - return html` - <div> - <p>Count: ${this.count}</p> - <button type="button" @click=${this.increment}>Increment</button> - </div> - `; - } -} - -customElements.define(tagName, Counter); diff --git a/examples/framework-multiple/src/components/PreactCounter.tsx b/examples/framework-multiple/src/components/PreactCounter.tsx index 261f275a1..2fb0a54b9 100644 --- a/examples/framework-multiple/src/components/PreactCounter.tsx +++ b/examples/framework-multiple/src/components/PreactCounter.tsx @@ -1,6 +1,8 @@ +/** @jsxImportSource preact */ + import { useState } from 'preact/hooks'; -/** a counter written in Preact */ +/** A counter written with Preact */ export function PreactCounter({ children }) { const [count, setCount] = useState(0); const add = () => setCount((i) => i + 1); diff --git a/examples/framework-multiple/src/components/PreactSFC.tsx b/examples/framework-multiple/src/components/PreactSFC.tsx deleted file mode 100644 index 60d0fe836..000000000 --- a/examples/framework-multiple/src/components/PreactSFC.tsx +++ /dev/null @@ -1,10 +0,0 @@ -/** @jsxImportSource preact */ - -/** a counter written in Preact */ -export default function PreactSFC({ children }) { - return ( - <> - <div className="counter">Hello from Preact!</div> - </> - ); -} diff --git a/examples/framework-multiple/src/components/ReactCounter.jsx b/examples/framework-multiple/src/components/ReactCounter.tsx index cdd42bee2..1cff97917 100644 --- a/examples/framework-multiple/src/components/ReactCounter.jsx +++ b/examples/framework-multiple/src/components/ReactCounter.tsx @@ -1,6 +1,6 @@ import { useState } from 'react'; -/** a counter written in React */ +/** A counter written with React */ export function Counter({ children }) { const [count, setCount] = useState(0); const add = () => setCount((i) => i + 1); diff --git a/examples/framework-multiple/src/components/SolidCounter.tsx b/examples/framework-multiple/src/components/SolidCounter.tsx index b16a463d5..153feaddc 100644 --- a/examples/framework-multiple/src/components/SolidCounter.tsx +++ b/examples/framework-multiple/src/components/SolidCounter.tsx @@ -1,6 +1,8 @@ +/** @jsxImportSource solid-js */ + import { createSignal } from 'solid-js'; -/** a counter written with Solid */ +/** A counter written with Solid */ export default function SolidCounter({ children }) { const [count, setCount] = createSignal(0); const add = () => setCount(count() + 1); diff --git a/examples/framework-multiple/src/components/SvelteCounter.svelte b/examples/framework-multiple/src/components/SvelteCounter.svelte index 3cab8c43a..01e58574a 100644 --- a/examples/framework-multiple/src/components/SvelteCounter.svelte +++ b/examples/framework-multiple/src/components/SvelteCounter.svelte @@ -1,22 +1,23 @@ +<!-- @component +A counter written with Svelte +--> +<script lang="ts"> + let count = 0; -<script> - let children; - let count = 0; - - function add() { + function add() { count += 1; } - function subtract() { + function subtract() { count -= 1; } </script> <div class="counter"> - <button on:click={subtract}>-</button> - <pre>{ count }</pre> - <button on:click={add}>+</button> + <button on:click={subtract}>-</button> + <pre>{count}</pre> + <button on:click={add}>+</button> </div> <div class="counter-message"> - <slot /> + <slot /> </div> diff --git a/examples/framework-multiple/src/components/VueCounter.vue b/examples/framework-multiple/src/components/VueCounter.vue index bd801ca81..74820f7f0 100644 --- a/examples/framework-multiple/src/components/VueCounter.vue +++ b/examples/framework-multiple/src/components/VueCounter.vue @@ -1,4 +1,10 @@ <template> + <!-- + Seeing type errors on the word `class`? + This unfortunately happens because @types/react's JSX definitions leak into every file due to being declared globally. + There's currently no way to prevent this when using both Vue and React with TypeScript in the same project. + You can read more about this issue here: https://github.com/johnsoncodehk/volar/discussions/592 + --> <div class="counter"> <button @click="subtract()">-</button> <pre>{{ count }}</pre> @@ -9,7 +15,7 @@ </div> </template> -<script> +<script lang="ts"> import { ref } from 'vue'; export default { setup() { diff --git a/examples/framework-multiple/src/components/index.ts b/examples/framework-multiple/src/components/index.ts deleted file mode 100644 index 4077dcacd..000000000 --- a/examples/framework-multiple/src/components/index.ts +++ /dev/null @@ -1,2 +0,0 @@ -export { default as A } from './A.astro'; -export { default as B } from './B.astro'; |