diff options
| author |  Tony Sullivan <tony.f.sullivan@outlook.com>
| 2021-07-08 20:07:56 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-07-08 14:07:56 -0400 |
| commit | 0a7b6deaec9fa32c2cb7139ac9aeaa242c0a7f4c (patch) | |
| tree | d8ff047bea3e4496b06990a44d24c05e81e595a3 /examples/with-markdown/src | |
| parent | ea5afcd6334c25c7a38f8f381d400bef1bb6dbc9 (diff) | |
| download | astro-0a7b6deaec9fa32c2cb7139ac9aeaa242c0a7f4c.tar.gz astro-0a7b6deaec9fa32c2cb7139ac9aeaa242c0a7f4c.tar.zst astro-0a7b6deaec9fa32c2cb7139ac9aeaa242c0a7f4c.zip | |
Move hydration directives to special attributes (#618)
* feat: :recycle: updating hydration to work with the directive syntax
* test: :white_check_mark: Updating tests for the hydration directive syntax
* refactor: Updating example projects for the hydration directive syntax
* test: :white_check_mark: Found a test fixture still needing an update to the hydration directive syntax
* style: Prettier strikes again! Reverting code formatting changes
* refactor: :recycle: moving directive matching to a Set
* refactor: Updating syntax to `client:load`
* refactor: :recycle: Simplifying the `client:` directive match
Per PR feedback from @matthewp
* chore: errant console.warn() snuck into the last commit
* feat: :loud_sound: Adding a super fancy build warning to update to the directive syntax
* refactor: :recycle: Removing unnecessary checks when matching supported hydration directives
`val` isn't being used for now, but leaving it in the attr destructuring as a reminder since it'll be needed for `client:media`
* test: :white_check_mark: Including the original hydration syntax in a test to make sure it builds
* style: :memo: Adding a comment to make it clear why the old hydration syntax is included in a the test markup
* fix: :bug: updating `head` logic to recognize hydration directive syntax
* docs: Adding changeset
* refactor: :fire: Removing unnecessary `!hasComponents` check
* docs: :memo: Adding more detail to the changset
Co-authored-by: Tony Sullivan <tony.f.sullivan@gmail.com>
Diffstat (limited to 'examples/with-markdown/src')
| -rw-r--r-- | examples/with-markdown/src/pages/index.astro | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/examples/with-markdown/src/pages/index.astro b/examples/with-markdown/src/pages/index.astro index 6e402fb1c..b6843f3a5 100644 --- a/examples/with-markdown/src/pages/index.astro +++ b/examples/with-markdown/src/pages/index.astro @@ -32,10 +32,10 @@ const items = ['A', 'B', 'C']; ## Embed framework components - <ReactCounter:visible /> - <PreactCounter:visible /> - <VueCounter:visible /> - <SvelteCounter:visible /> + <ReactCounter client:visible /> + <PreactCounter client:visible /> + <VueCounter client:visible /> + <SvelteCounter client:visible /> ## Use Expressions @@ -43,11 +43,11 @@ const items = ['A', 'B', 'C']; ## Oh yeah... - <ReactCounter:visible> + <ReactCounter client:visible> 🤯 It's also _recursive_! ### Markdown can be embedded in any child component - </ReactCounter:visible> + </ReactCounter> ## Code |