diff options
| author |  Arsh <69170106+lilnasy@users.noreply.github.com>
| 2024-02-01 07:02:40 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-02-01 07:02:40 +0000 |
| commit | a4030275160d81bc87fdf533e6aa8a3de6542a16 (patch) | |
| tree | 7770783333d985c3f446f6c570915ae4337d5eb3 /packages/integrations/node/test/errors.test.js | |
| parent | 3f967e5605d85b487393f8632bd346ec47d9185e (diff) | |
| download | astro-a4030275160d81bc87fdf533e6aa8a3de6542a16.tar.gz astro-a4030275160d81bc87fdf533e6aa8a3de6542a16.tar.zst astro-a4030275160d81bc87fdf533e6aa8a3de6542a16.zip | |
fix(NodeApp): end with "Internal server error" on mid-stream error (#9908)
* fix(NodeApp): end with "Internal server error" on mid-stream error
* add changeset
* add test
* Apply suggestions from code review
---------
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Diffstat (limited to 'packages/integrations/node/test/errors.test.js')
| -rw-r--r-- | packages/integrations/node/test/errors.test.js | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/packages/integrations/node/test/errors.test.js b/packages/integrations/node/test/errors.test.js index 983187475..23deba02c 100644 --- a/packages/integrations/node/test/errors.test.js +++ b/packages/integrations/node/test/errors.test.js @@ -1,4 +1,4 @@ -import * as assert from 'node:assert/strict'; +import assert from 'node:assert/strict'; import { describe, it, before, after } from 'node:test'; import nodejs from '../dist/index.js'; import { loadFixture } from './test-utils.js'; @@ -22,11 +22,26 @@ describe('Errors', () => { after(async () => { await devPreview.stop(); }); - it('when mode is standalone', async () => { + + it('rejected promise in template', async () => { const res = await fixture.fetch('/in-stream'); const html = await res.text(); const $ = cheerio.load(html); assert.equal($('p').text().trim(), 'Internal server error'); }); + + it('generator that throws called in template', async () => { + /** @type {Response} */ + const res = await fixture.fetch('/generator'); + const reader = res.body.getReader(); + const decoder = new TextDecoder(); + const expect = async ({ done, value }) => { + const result = await reader.read(); + assert.equal(result.done, done); + if (!done) assert.equal(decoder.decode(result.value), value); + } + await expect({ done: false, value: "<!DOCTYPE html><h1>Astro</h1> 1Internal server error" }); + await expect({ done: true }); + }); }); |