#7226 - fixes NodeJS adapter for multiple set-cookie headers (and other header issues) (#7227)

* Utilizes the new standard WebAPI Fetch Headers.getSetCookie() function
to safely handle multiple set-cookie headers when converting from a
WebAPI Response to a NodeJS ServerResponse

Modifies the existing nodeMiddleware logic which first set AstroCookies
on ServerResponse.setHeader(...) and then called
ServerResponse.writeHead(status, Response.headers) which means any that
if the WebAPI Response had any set-cookie headers on it, they would
replace anything from AstroCookies.

The new logic delegates appending AstroCookie values onto the WebAPI
Response Headers object, so that a single unified function safely
converts the WebAPI Response Headers into a NodeJS compatible
OutgoingHttpHeaders object utilizing the new standard
Headers.getSetCookie() function provided by the undici WebAPI polyfills.

Plus extensive test coverage.

* #7226 - changeset for NodeJS adapter set-cookie fix

* fixing all double quotes to single quotes

---------

Co-authored-by: Alex Sherwin <alex.sherwin@acadia.inc>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

1 files changed, 148 insertions, 0 deletions

diff --git a/packages/integrations/node/test/headers.test.js.js b/packages/integrations/node/test/headers.test.js.js
new file mode 100644
index 000000000..5b453dd56
--- /dev/null
+++ b/packages/integrations/node/test/headers.test.js.js
@@ -0,0 +1,148 @@
+import nodejs from '../dist/index.js';
+import { loadFixture, createRequestAndResponse } from './test-utils.js';
+import { expect } from 'chai';
+
+describe('Node Adapter Headers', () => {
+  /** @type {import('./test-utils').Fixture} */
+  let fixture;
+
+  before(async () => {
+    fixture = await loadFixture({
+      root: './fixtures/headers/',
+      output: 'server',
+      adapter: nodejs({ mode: 'middleware' }),
+    });
+    await fixture.build();
+  });
+
+  it('Endpoint Simple Headers', async () => {
+    await runTest('/endpoints/simple', {
+      'content-type': 'text/plain;charset=utf-8',
+      'x-hello': 'world',
+    });
+  });
+
+  it('Endpoint Astro Single Cookie Header', async () => {
+    await runTest('/endpoints/astro-cookies-single', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': 'from1=astro1',
+    });
+  });
+
+  it('Endpoint Astro Multi Cookie Header', async () => {
+    await runTest('/endpoints/astro-cookies-multi', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': ['from1=astro1', 'from2=astro2'],
+    });
+  });
+
+  it('Endpoint Response Single Cookie Header', async () => {
+    await runTest('/endpoints/response-cookies-single', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': 'hello1=world1',
+    });
+  });
+
+  it('Endpoint Response Multi Cookie Header', async () => {
+    await runTest('/endpoints/response-cookies-multi', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': ['hello1=world1', 'hello2=world2'],
+    });
+  });
+
+  it('Endpoint Complex Headers Kitchen Sink', async () => {
+    await runTest('/endpoints/kitchen-sink', {
+      'content-type': 'text/plain;charset=utf-8',
+      'x-single': 'single',
+      'x-triple': 'one, two, three',
+      'set-cookie': ['hello1=world1', 'hello2=world2'],
+    });
+  });
+
+  it('Endpoint Astro and Response Single Cookie Header', async () => {
+    await runTest('/endpoints/astro-response-cookie-single', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': ['from1=response1', 'from1=astro1'],
+    });
+  });
+
+  it('Endpoint Astro and Response Multi Cookie Header', async () => {
+    await runTest('/endpoints/astro-response-cookie-multi', {
+      'content-type': 'text/plain;charset=utf-8',
+      'set-cookie': ['from1=response1', 'from2=response2', 'from3=astro1', 'from4=astro2'],
+    });
+  });
+
+  it('Endpoint Response Empty Headers Object', async () => {
+    await runTest('/endpoints/response-empty-headers-object', {
+      'content-type': 'text/plain;charset=UTF-8',
+    });
+  });
+
+  it('Endpoint Response undefined Headers Object', async () => {
+    await runTest('/endpoints/response-undefined-headers-object', {
+      'content-type': 'text/plain;charset=UTF-8',
+    });
+  });
+
+  it('Component Astro Single Cookie Header', async () => {
+    await runTest('/astro/component-astro-cookies-single', {
+      'content-type': 'text/html',
+      'set-cookie': 'from1=astro1',
+    });
+  });
+
+  it('Component Astro Multi Cookie Header', async () => {
+    await runTest('/astro/component-astro-cookies-multi', {
+      'content-type': 'text/html',
+      'set-cookie': ['from1=astro1', 'from2=astro2'],
+    });
+  });
+
+  it('Component Response Single Cookie Header', async () => {
+    await runTest('/astro/component-response-cookies-single', {
+      'content-type': 'text/html',
+      'set-cookie': 'from1=value1',
+    });
+  });
+
+  it('Component Response Multi Cookie Header', async () => {
+    await runTest('/astro/component-response-cookies-multi', {
+      'content-type': 'text/html',
+      'set-cookie': ['from1=value1', 'from2=value2'],
+    });
+  });
+
+  it('Component Astro and Response Single Cookie Header', async () => {
+    await runTest('/astro/component-astro-response-cookie-single', {
+      'content-type': 'text/html',
+      'set-cookie': ['from1=response1', 'from1=astro1'],
+    });
+  });
+
+  it('Component Astro and Response Multi Cookie Header', async () => {
+    await runTest('/astro/component-astro-response-cookie-multi', {
+      'content-type': 'text/html',
+      'set-cookie': ['from1=response1', 'from2=response2', 'from3=astro1', 'from4=astro2'],
+    });
+  });
+
+});
+
+async function runTest(url, expectedHeaders) {
+  const { handler } = await import('./fixtures/headers/dist/server/entry.mjs');
+
+  let { req, res, done } = createRequestAndResponse({
+    method: 'GET',
+    url,
+  });
+
+  handler(req, res);
+
+  req.send();
+
+  await done;
+  const headers = res.getHeaders();
+
+  expect(headers).to.deep.equal(expectedHeaders);
+}
\ No newline at end of file