summaryrefslogtreecommitdiff
path: root/packages/integrations/preact/src
diff options
context:
space:
mode:
authorGravatar Bjorn Lu <bjornlu.dev@gmail.com> 2024-08-09 20:01:25 +0800
committerGravatar GitHub <noreply@github.com> 2024-08-09 20:01:25 +0800
commit7adb350a37f3975c8c9db89a32bf63b9fd0b78c2 (patch)
treefd767f5fd91f75565fb257ff7ce5ffe544754da4 /packages/integrations/preact/src
parentcc405dd1feeba05807f16ff3a0fa281090001f37 (diff)
downloadastro-7adb350a37f3975c8c9db89a32bf63b9fd0b78c2.tar.gz
astro-7adb350a37f3975c8c9db89a32bf63b9fd0b78c2.tar.zst
astro-7adb350a37f3975c8c9db89a32bf63b9fd0b78c2.zip
Prevent throwing in react and solid component checks (#11624)
Diffstat (limited to 'packages/integrations/preact/src')
-rw-r--r--packages/integrations/preact/src/server.ts20
1 files changed, 9 insertions, 11 deletions
diff --git a/packages/integrations/preact/src/server.ts b/packages/integrations/preact/src/server.ts
index 932cacb99..5b38ff590 100644
--- a/packages/integrations/preact/src/server.ts
+++ b/packages/integrations/preact/src/server.ts
@@ -27,19 +27,17 @@ async function check(
useConsoleFilter();
try {
- try {
- const { html } = await renderToStaticMarkup.call(this, Component, props, children, undefined);
- if (typeof html !== 'string') {
- return false;
- }
-
- // There are edge cases (SolidJS) where Preact *might* render a string,
- // but components would be <undefined></undefined>
- // It also might render an empty sting.
- return html == '' ? false : !html.includes('<undefined>');
- } catch {
+ const { html } = await renderToStaticMarkup.call(this, Component, props, children, undefined);
+ if (typeof html !== 'string') {
return false;
}
+
+ // There are edge cases (SolidJS) where Preact *might* render a string,
+ // but components would be <undefined></undefined>
+ // It also might render an empty sting.
+ return html == '' ? false : !html.includes('<undefined>');
+ } catch {
+ return false;
} finally {
finishUsingConsoleFilter();
}