diff options
| author |  Ben Holmes <hey@bholmes.dev>
| 2022-06-02 13:35:03 -0400 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-06-02 13:35:03 -0400 |
| commit | 2b35650b5dca28b5cd5dd7c9bb689d0eee6a2ddf (patch) | |
| tree | 71379e9dac6b806daea08bd5573c190713782d2e /packages/integrations/solid/src | |
| parent | 45ae85c32f168c37b50331b5643bc5ff251066cf (diff) | |
| download | astro-2b35650b5dca28b5cd5dd7c9bb689d0eee6a2ddf.tar.gz astro-2b35650b5dca28b5cd5dd7c9bb689d0eee6a2ddf.tar.zst astro-2b35650b5dca28b5cd5dd7c9bb689d0eee6a2ddf.zip | |
Fix: newline characters in Solid (#3505)
* fix: remove source map consumption from babel transform
* refactor: move inputSourceMap to integration option
* tests: add newline ex to test build and dev
* chore: change back to babel.transformAsync
* chore: changeset
Diffstat (limited to 'packages/integrations/solid/src')
| -rw-r--r-- | packages/integrations/solid/src/index.ts | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/packages/integrations/solid/src/index.ts b/packages/integrations/solid/src/index.ts index 1205c6d09..00c61a75a 100644 --- a/packages/integrations/solid/src/index.ts +++ b/packages/integrations/solid/src/index.ts @@ -12,6 +12,10 @@ function getRenderer(): AstroRenderer { const options = { presets: [solid({}, { generate: ssr ? 'ssr' : 'dom', hydratable: true })], plugins: [], + // Otherwise, babel will try to consume the source map generated by esbuild + // This causes unexpected issues with newline characters: https://github.com/withastro/astro/issues/3371 + // Note "vite-plugin-solid" does the same: https://github.com/solidjs/vite-plugin-solid/blob/master/src/index.ts#L344-L345 + inputSourceMap: false as any, }; return options; |