aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2022-07-02 01:33:59 -0700
committerGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2022-07-02 01:36:04 -0700
commitba2c24e77cac9a47014773646f1c4d9d6aedd64a (patch)
tree2e5cd7604527bf4353f0e83e714022171d04d1df
parentd1cc2b85cb6b27b67be2f6307e708f7d6bde615b (diff)
downloadbun-ba2c24e77cac9a47014773646f1c4d9d6aedd64a.tar.gz
bun-ba2c24e77cac9a47014773646f1c4d9d6aedd64a.tar.zst
bun-ba2c24e77cac9a47014773646f1c4d9d6aedd64a.zip
[bindings] Mark more stuff as unreachable
-rw-r--r--src/bun.js/test/jest.zig13
1 files changed, 2 insertions, 11 deletions
diff --git a/src/bun.js/test/jest.zig b/src/bun.js/test/jest.zig
index 2e95651c0..5d68c3dcc 100644
--- a/src/bun.js/test/jest.zig
+++ b/src/bun.js/test/jest.zig
@@ -376,16 +376,6 @@ pub const Expect = struct {
}
if (!eql) {
- if (comptime Environment.allow_assert) {
- if (left.isString() and right.isString()) {
- var left_slice = left.toSlice(ctx, getAllocator(ctx));
- defer left_slice.deinit();
- var right_slice = right.toSlice(ctx, getAllocator(ctx));
- defer right_slice.deinit();
- std.debug.assert(!strings.eqlLong(left_slice.slice(), right_slice.slice(), true));
- }
- }
-
var lhs_formatter: JSC.ZigConsoleClient.Formatter = JSC.ZigConsoleClient.Formatter{ .globalThis = ctx.ptr() };
var rhs_formatter: JSC.ZigConsoleClient.Formatter = JSC.ZigConsoleClient.Formatter{ .globalThis = ctx.ptr() };
@@ -688,7 +678,7 @@ pub const TestScope = struct {
js.JSValueUnprotect(vm.global.ref(), this.callback);
this.callback = null;
}
-
+ JSC.markBinding();
const initial_value = js.JSObjectCallAsFunctionReturnValue(vm.global.ref(), this.callback, null, 0, null);
if (initial_value.isException(vm.global.vm()) or initial_value.isError() or initial_value.isAggregateError(vm.global)) {
@@ -897,6 +887,7 @@ pub const DescribeScope = struct {
active = this;
{
+ JSC.markBinding();
var result = js.JSObjectCallAsFunctionReturnValue(ctx, callback, thisObject, 0, null);
if (result.asPromise() != null or result.asInternalPromise() != null) {