aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-12-31 15:08:58 -0800
committerGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-12-31 15:08:58 -0800
commit195723180bf046a72808aacc02041b02ba84f122 (patch)
tree9d2448f0543a103a5b3cfaec4abf7f58613aef60
parent2e051cebaaf8b465f5aadf30f461b88c17a041bf (diff)
downloadbun-195723180bf046a72808aacc02041b02ba84f122.tar.gz
bun-195723180bf046a72808aacc02041b02ba84f122.tar.zst
bun-195723180bf046a72808aacc02041b02ba84f122.zip
[devserver] Log more errors when a websocket connection fails
-rw-r--r--src/http.zig11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/http.zig b/src/http.zig
index 227b8eaad..ed1dd9cae 100644
--- a/src/http.zig
+++ b/src/http.zig
@@ -1734,8 +1734,14 @@ pub const RequestContext = struct {
self: *WebsocketHandler,
) !u8 {
var request: *RequestContext = &self.ctx;
- const v = request.header("Sec-WebSocket-Version") orelse return error.BadRequest;
- return std.fmt.parseInt(u8, v.value, 10) catch error.BadRequest;
+ const v = request.header("Sec-WebSocket-Version") orelse {
+ Output.prettyErrorln("HMR WebSocket error: missing Sec-WebSocket-Version header", .{});
+ return error.BadRequest;
+ };
+ return std.fmt.parseInt(u8, v.value, 10) catch {
+ Output.prettyErrorln("HMR WebSocket error: Sec-WebSocket-Version is invalid {s}", .{v.value});
+ return error.BadRequest;
+ };
}
fn getWebsocketAcceptKey(
@@ -1744,6 +1750,7 @@ pub const RequestContext = struct {
var request: *RequestContext = &self.ctx;
const key = (request.header("Sec-WebSocket-Key") orelse return error.BadRequest).value;
if (key.len < 8) {
+ Output.prettyErrorln("HMR WebSocket error: Sec-WebSocket-Key is less than 8 characters long: {s}", .{key});
return error.BadRequest;
}