diff options
| author |  Alex Lam S.L <alexlamsl@gmail.com>
| 2023-01-05 13:31:01 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-01-05 03:31:01 -0800 |
| commit | 20718b972e19857332a8eabdbafcb46751320af5 (patch) | |
| tree | f6afdca19ff5c864f2b9d0b59953e7488f09f129 | |
| parent | a951859c5560254f202f9688ce8e0861c51a5411 (diff) | |
| download | bun-20718b972e19857332a8eabdbafcb46751320af5.tar.gz bun-20718b972e19857332a8eabdbafcb46751320af5.tar.zst bun-20718b972e19857332a8eabdbafcb46751320af5.zip | |
fix `onConnectError()` error propagation (#1730)
* fix `onConnectError()` error propagation
suppress extraneous logging messages
* Update src/bun.js/api/bun/socket.zig
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
| -rw-r--r-- | src/bun.js/api/bun/socket.zig | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bun.js/api/bun/socket.zig b/src/bun.js/api/bun/socket.zig index f3a1d2646..bded03f7f 100644 --- a/src/bun.js/api/bun/socket.zig +++ b/src/bun.js/api/bun/socket.zig @@ -913,8 +913,8 @@ fn NewSocket(comptime ssl: bool) type { err_value, }); - _ = handlers.rejectPromise(err_value); - if (!result.isEmptyOrUndefinedOrNull() and result.isAnyError(globalObject)) { + if (result.isAnyError(globalObject)) { + if (handlers.rejectPromise(result)) return; _ = handlers.callErrorHandler(this_value, &[_]JSC.JSValue{ this_value, result }); } } |