aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-10-24 15:53:27 -0700
committerGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-10-24 15:53:27 -0700
commit35829417915d3dc0d60da7719b7e586a983ecac5 (patch)
tree219cfb07b2e3f0cc672fe66621426b53a45cdc1f
parenta3cd9347e6dfd435d3eb7b72395418091276e79c (diff)
downloadbun-35829417915d3dc0d60da7719b7e586a983ecac5.tar.gz
bun-35829417915d3dc0d60da7719b7e586a983ecac5.tar.zst
bun-35829417915d3dc0d60da7719b7e586a983ecac5.zip
[internal] Use isPresent() instead of checking slice len
-rw-r--r--src/js_parser/js_parser.zig4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/js_parser/js_parser.zig b/src/js_parser/js_parser.zig
index 049ac34a4..e135c3f7d 100644
--- a/src/js_parser/js_parser.zig
+++ b/src/js_parser/js_parser.zig
@@ -1461,7 +1461,7 @@ pub const SideEffects = enum(u2) {
return Result{ .ok = true, .value = !strings.eqlComptime(e.value, "0"), .side_effects = .no_side_effects };
},
.e_string => |e| {
- return Result{ .ok = true, .value = std.math.max(e.value.len, e.utf8.len) > 0, .side_effects = .no_side_effects };
+ return Result{ .ok = true, .value = e.isPresent(), .side_effects = .no_side_effects };
},
.e_function, .e_arrow, .e_reg_exp => {
return Result{ .ok = true, .value = true, .side_effects = .no_side_effects };
@@ -2101,7 +2101,7 @@ pub const Parser = struct {
fn _parse(self: *Parser, comptime ParserType: type) !js_ast.Result {
var p: ParserType = undefined;
try ParserType.init(self.allocator, self.log, self.source, self.define, self.lexer, self.options, &p);
-
+ defer p.lexer.deinit();
var result: js_ast.Result = undefined;
// Consume a leading hashbang comment