diff options
| author |  Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
| 2023-07-27 18:01:01 -0700 |
|---|---|---|
| committer | Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
| 2023-07-27 18:01:01 -0700 |
| commit | 65d0884361f349f06f461c7a7be7e2dc12479e54 (patch) | |
| tree | 6347a007f8eb92aea52106c87c94135abd9791b3 | |
| parent | 16fdc074cae9297d5b868c8a71dc8f597104794c (diff) | |
| download | bun-65d0884361f349f06f461c7a7be7e2dc12479e54.tar.gz bun-65d0884361f349f06f461c7a7be7e2dc12479e54.tar.zst bun-65d0884361f349f06f461c7a7be7e2dc12479e54.zip | |
Update pull_request_template.md
| -rw-r--r-- | .github/pull_request_template.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index af4fd9990..a71a6c6e5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -34,6 +34,10 @@ If Zig files changed: - [ ] I included a test for the new code, or an existing test covers it - [ ] JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed +If new methods, getters, or setters were added to a publicly exposed class: + +- [ ] I added TypeScript types for the new methods, getters, or setters + If dependencies in tests changed: - [ ] I made sure that specific versions of dependencies are used instead of ranged or tagged versions |