[bun:sqlite] Fix bug with latin1 supplemental characters

Fixes https://github.com/oven-sh/bun/issues/1553

2 files changed, 31 insertions, 2 deletions

diff --git a/src/bun.js/bindings/sqlite/JSSQLStatement.cpp b/src/bun.js/bindings/sqlite/JSSQLStatement.cpp
index 524c131af..9873bd400 100644
--- a/src/bun.js/bindings/sqlite/JSSQLStatement.cpp
+++ b/src/bun.js/bindings/sqlite/JSSQLStatement.cpp
@@ -286,10 +286,13 @@ static inline bool rebindValue(JSC::JSGlobalObject* lexicalGlobalObject, sqlite3
             return false;
         }
 
-        if (roped.is8Bit()) {
+        if (roped.is8Bit() && roped.isAllASCII()) {
             CHECK_BIND(sqlite3_bind_text(stmt, i, reinterpret_cast<const char*>(roped.characters8()), roped.length(), transientOrStatic));
-        } else {
+        } else if (!roped.is8Bit()) {
             CHECK_BIND(sqlite3_bind_text16(stmt, i, roped.characters16(), roped.length() * 2, transientOrStatic));
+        } else {
+            auto utf8 = roped.utf8();
+            CHECK_BIND(sqlite3_bind_text(stmt, i, utf8.data(), utf8.length(), SQLITE_TRANSIENT));
         }
 
     } else if (UNLIKELY(value.isHeapBigInt())) {
diff --git a/test/bun.js/sqlite.test.js b/test/bun.js/sqlite.test.js
index 2bf7fc72d..882454fb8 100644
--- a/test/bun.js/sqlite.test.js
+++ b/test/bun.js/sqlite.test.js
@@ -494,3 +494,29 @@ it("inlineCapacity #987", async () => {
 
   expect(Object.keys(db.query(query).all()[0]).length).toBe(99);
 });
+
+// https://github.com/oven-sh/bun/issues/1553
+it("latin1 supplement chars", () => {
+  const db = new Database();
+  db.run(
+    "CREATE TABLE IF NOT EXISTS foo (id INTEGER PRIMARY KEY AUTOINCREMENT, greeting TEXT)",
+  );
+  db.run("INSERT INTO foo (greeting) VALUES (?)", "Welcome to bun!");
+  db.run("INSERT INTO foo (greeting) VALUES (?)", "Español");
+  db.run("INSERT INTO foo (greeting) VALUES (?)", "¿Qué sucedió?");
+
+  expect(db.query("SELECT * FROM foo").all()).toEqual([
+    {
+      id: 1,
+      greeting: "Welcome to bun!",
+    },
+    {
+      id: 2,
+      greeting: "Español",
+    },
+    {
+      id: 3,
+      greeting: "¿Qué sucedió?",
+    },
+  ]);
+});