fix(node:process): fix return value of `process.kill` (#6207)

3 files changed, 6 insertions, 4 deletions

diff --git a/packages/bun-types/globals.d.ts b/packages/bun-types/globals.d.ts
index a1f1bd325..ea73b506d 100644
--- a/packages/bun-types/globals.d.ts
+++ b/packages/bun-types/globals.d.ts
@@ -681,7 +681,7 @@ interface Process {
    */
   setSourceMapsEnabled(enabled: boolean): void;
 
-  kill(pid: number, signal?: string | number): void;
+  kill(pid: number, signal?: string | number): true;
 
   on(event: "beforeExit", listener: BeforeExitListener): this;
   // on(event: "disconnect", listener: DisconnectListener): this;
diff --git a/src/bun.js/bindings/Process.cpp b/src/bun.js/bindings/Process.cpp
index d82d403d3..1caff9be9 100644
--- a/src/bun.js/bindings/Process.cpp
+++ b/src/bun.js/bindings/Process.cpp
@@ -1835,7 +1835,7 @@ JSC_DEFINE_HOST_FUNCTION(Process_functionKill,
         return JSValue::encode(jsUndefined());
     }
 
-    return JSValue::encode(jsUndefined());
+    return JSValue::encode(jsBoolean(true));
 }
 
 extern "C" void Process__emitMessageEvent(Zig::GlobalObject* global, EncodedJSValue value)
diff --git a/test/js/node/process/process.test.js b/test/js/node/process/process.test.js
index a4a8862a2..4fb678dce 100644
--- a/test/js/node/process/process.test.js
+++ b/test/js/node/process/process.test.js
@@ -407,7 +407,8 @@ describe("signal", () => {
       stdout: "pipe",
     });
     const prom = child.exited;
-    process.kill(child.pid, "SIGTERM");
+    const ret = process.kill(child.pid, "SIGTERM");
+    expect(ret).toBe(true);
     await prom;
     expect(child.signalCode).toBe("SIGTERM");
   });
@@ -418,7 +419,8 @@ describe("signal", () => {
       stdout: "pipe",
     });
     const prom = child.exited;
-    process.kill(child.pid, 9);
+    const ret = process.kill(child.pid, 9);
+    expect(ret).toBe(true);
     await prom;
     expect(child.signalCode).toBe("SIGKILL");
   });