diff options
author | 2023-01-16 21:20:21 -0800 | |
---|---|---|
committer | 2023-01-16 21:20:54 -0800 | |
commit | d21119b347168c5f401e64bb7f40b9b6399bc703 (patch) | |
tree | 6d54864383286a821ea6a36d766acf0cf12415b9 | |
parent | d3de366c67c4a7012ab5b83fd9dd3c12a925d9d0 (diff) | |
download | bun-d21119b347168c5f401e64bb7f40b9b6399bc703.tar.gz bun-d21119b347168c5f401e64bb7f40b9b6399bc703.tar.zst bun-d21119b347168c5f401e64bb7f40b9b6399bc703.zip |
remove onClose
-rw-r--r-- | test/bun.js/socket/node-net.test.ts | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/test/bun.js/socket/node-net.test.ts b/test/bun.js/socket/node-net.test.ts index 28e3f152f..504a83496 100644 --- a/test/bun.js/socket/node-net.test.ts +++ b/test/bun.js/socket/node-net.test.ts @@ -170,16 +170,13 @@ describe("net.Socket write", () => { function runWithServer(cb) { return (done) => { - let onClose, server; + let server; function close(socket) { - if (onClose) { - const done = onClose; - onClose = null; - expect(Buffer.concat(socket.data).toString("utf8")).toBe(message); - done(); - } + expect(Buffer.concat(socket.data).toString("utf8")).toBe(message); + done(); } + var leaky; server = Bun.listen({ hostname: "0.0.0.0", @@ -193,7 +190,7 @@ describe("net.Socket write", () => { end: close, error(socket, err) { leaky = socket; - onClose(err); + done(err); }, open(socket) { leaky = socket; @@ -216,7 +213,7 @@ describe("net.Socket write", () => { }; } - it.skip( + it( "should work with .end(data)", runWithServer((server, done) => { const socket = new Socket() @@ -230,7 +227,7 @@ describe("net.Socket write", () => { }), ); - it.skip( + it( "should work with .write(data).end()", runWithServer((server, done) => { const socket = new Socket() @@ -244,7 +241,7 @@ describe("net.Socket write", () => { }), ); - it.skip( + it( "should work with multiple .write()s", runWithServer((server, done) => { const socket = new Socket() |