aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2023-01-17 20:10:19 -0800
committerGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2023-01-17 20:10:19 -0800
commite0eeb1c07e95e1f872b177c7c25afe3bc5898b7c (patch)
treea385ab94687a7a9f28f3cc255229f4aec3dd9abe
parent216e872801a026c624ffa98cb15d73541e085735 (diff)
downloadbun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.tar.gz
bun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.tar.zst
bun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.zip
workaround lifetime issue
-rw-r--r--src/bun.js/bindings/ImportMetaObject.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bun.js/bindings/ImportMetaObject.cpp b/src/bun.js/bindings/ImportMetaObject.cpp
index 0247b5140..be46e5332 100644
--- a/src/bun.js/bindings/ImportMetaObject.cpp
+++ b/src/bun.js/bindings/ImportMetaObject.cpp
@@ -122,12 +122,12 @@ JSC_DEFINE_CUSTOM_GETTER(functionRequireResolveLazyGetter,
}
JSValue pathStringValue = require->get(globalObject, PropertyName(builtinNames.pathPrivateName()));
- JSC::Strong<JSC::JSString> pathString = JSC::Strong<JSC::JSString>(vm, pathStringValue.toStringOrNull(globalObject));
+ WTF::String pathString = pathStringValue.toWTFString(globalObject);
JSC::JSFunction* resolverFunction
= JSC::JSNativeStdFunction::create(
globalObject->vm(), globalObject, 2, "resolve"_s, [pathString_ = WTFMove(pathString)](JSC::JSGlobalObject* globalObject, JSC::CallFrame* callFrame) -> const JSC::EncodedJSValue {
- return functionRequireResolve(globalObject, callFrame, JSValue::encode(pathString_.get()));
+ return functionRequireResolve(globalObject, callFrame, JSValue::encode(jsString(globalObject->vm(), pathString_)));
});
require->putDirect(vm, builtinNames.resolvePrivateName(), resolverFunction, 0);
return JSValue::encode(JSValue(resolverFunction));