aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar dave caruso <me@paperdave.net> 2023-08-08 18:23:33 -0700
committerGravatar GitHub <noreply@github.com> 2023-08-08 18:23:33 -0700
commit320cdcf97e549c45ab50bbbc3c415dc011260f20 (patch)
treea20c5212aceff2603311fa153139a0dcf5bd4add
parent454407003e97d6896dc16d9b0145f50d183a0529 (diff)
downloadbun-320cdcf97e549c45ab50bbbc3c415dc011260f20.tar.gz
bun-320cdcf97e549c45ab50bbbc3c415dc011260f20.tar.zst
bun-320cdcf97e549c45ab50bbbc3c415dc011260f20.zip
Fix require("console") #3820 (#4073)
* Fix #3820 * Add Module (#4074)
-rw-r--r--src/bun.js/module_loader.zig1
-rw-r--r--src/bun.js/modules/NodeModuleModule.h6
-rw-r--r--test/js/node/module/node-module-module.test.js4
3 files changed, 9 insertions, 2 deletions
diff --git a/src/bun.js/module_loader.zig b/src/bun.js/module_loader.zig
index 9e2af7e9f..3932736fc 100644
--- a/src/bun.js/module_loader.zig
+++ b/src/bun.js/module_loader.zig
@@ -2396,6 +2396,7 @@ pub const HardcodedModule = enum {
.{ "node:child_process", .{ .path = "node:child_process" } },
.{ "node:constants", .{ .path = "node:constants" } },
.{ "node:console", .{ .path = "node:console" } },
+ .{ "console", .{ .path = "node:console" } },
.{ "node:querystring", .{ .path = "node:querystring" } },
.{ "querystring", .{ .path = "node:querystring" } },
.{ "node:domain", .{ .path = "node:domain" } },
diff --git a/src/bun.js/modules/NodeModuleModule.h b/src/bun.js/modules/NodeModuleModule.h
index 3f2caaba6..0be647c39 100644
--- a/src/bun.js/modules/NodeModuleModule.h
+++ b/src/bun.js/modules/NodeModuleModule.h
@@ -292,11 +292,13 @@ DEFINE_NATIVE_MODULE(NodeModule) {
exportNames.append(name);
exportValues.append(value);
};
- exportNames.reserveCapacity(14);
- exportValues.ensureCapacity(14);
+ exportNames.reserveCapacity(15);
+ exportValues.ensureCapacity(15);
exportNames.append(vm.propertyNames->defaultKeyword);
exportValues.append(defaultObject);
+ put(Identifier::fromString(vm, "Module"_s), defaultObject);
+
putNativeFn(Identifier::fromString(vm, "createRequire"_s),
jsFunctionNodeModuleCreateRequire);
putNativeFn(Identifier::fromString(vm, "paths"_s),
diff --git a/test/js/node/module/node-module-module.test.js b/test/js/node/module/node-module-module.test.js
index f91f8048e..58a81fb98 100644
--- a/test/js/node/module/node-module-module.test.js
+++ b/test/js/node/module/node-module-module.test.js
@@ -26,6 +26,10 @@ test("Module exists", () => {
expect(Module).toBeDefined();
});
+test("module.Module exists", () => {
+ expect(Module.Module === Module).toBeTrue();
+});
+
test("_nodeModulePaths() works", () => {
expect(() => {
_nodeModulePaths();