Bun gets a new bundler (#2312)

* alright now just gotta try running it

* fix a gajillion compiler errors

* even more code

* okay i fixed more errors

* wip

* Update launch.json

* Update string_builder.zig

* `fast_debug_build_mode` makes debug build 2x faster

* Update bundle_v2.zig

* more code!

* It bundles!

* Rename `Bun.Transpiler` to `Bun.Bundler`

* `import()` expressions almost work

* wip attempt to get import() expr to work

* Bundle namespace imports

* Attempt to fix the issue with import() unsuccessfully

* consider current working directory when resolving relative paths (#2313)

* consider current working directory when resolving relative paths

fixes #2298

* comment test

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

* support `expect().toThrow(/pattern/)` (#2314)

- fix time-zone-dependent test failure

* fix missing `Blob` error messages on Linux (#2315)

* fix & clean up tests (#2318)

- skip flaky tests when running as `root`
- use `expect().toThrow()`
- clean up temporary files after tests

* feat(tty): add some `tty.WriteStream` methods to `process.{stdout, stderr}` (#2320)

* feat(stdio): add some `tty.WriteStream` methods

* chore(builtins): add process builtin gen'd code

* Fix docker install command

* `bun test` on macOS in GitHub Actions (#2322)

* Fixes #2323

* throw invalid parameter errors in `crypto.scryptSync` (#2331)

* throw invalid parameter errors

* remove comptime, add empty buffer function

* remove error_name comptime

* Add reference documentation for bun:test (#2327)

* Reorganize tests (#2332)

* Fix html-rewriter.test.js

* fix the wrong thing being incremented in hmr example (#2334)

* Add more test harness

* Improve Benchmarking page, small fixes (#2339)

* Improve benchmarking page

* WIP

* Add typescript instructions to hot

* Document preload in Plugins. Fix loader in plugin types.

* Fix typo

* Fix links

* run prettier

* Document openInEditor

* improve `Buffer` compatibility with Node.js (#2341)

* improve `Buffer` compatibility with Node.js

* use `memmove()`
allow `encoding` to be `undefined`

* run `bun test` after macOS builds (#2343)

* "binary" is an alias of "latin1"

Fixes https://github.com/oven-sh/bun/issues/2110

* More spec compliant `Blob.prototype.type` (#2340)

* Make `Blob.prototype. type` more spec compliant

* Add a few more checks for isNumber()

* Fix `make headers`

* Safer JSValue.isString()

* More tests for blob.slice

* Make `Blob.prototype.type` more spec compliant

* Add isASCII check

* Fix types

* Fix failing type test

* Update blob.zig

* Update blob.zig

* Fix .eql check on empty values

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

* Fix bug in test runner

* Support `import()` expressions

* Implement `require()`

* clean up bit_set.zig slightly

* Move some things around

* misc cleanup

* Cleanup some things

* Fix a lot of stuff

* Fix `module.exports.fn = fn;` in ESM entry point

* Fix crash due when printing file

* Fix issue with class names

* Fix issue with `export default identifier`

* Update js_parser.zig

* optimization: inline single-property object acceses and arrays

* Fix undefined memory in renamed symbols list

* Handle call target

* wip

* Inline it

* Fix undefined memory issue when reclaiming blocks in ast

* Halt linking on any parse errors

* alias

* Rename `enable_bundling` to `enable_legacy_bundling`

* Workaround anonymous struct literal zig bug

* Use slower approach (without bitset) because it doesn't break after 8 symbols

* Fix incorrectly-renaming statically defined symbols

* Handle more edgecases in our bit_set fork

* Reduce number of allocations for `define`

* Do not rename unbound symbols

* Clean up dot defines a little more

* Make the generated names prettier

* Workaround runtime symbol missing issue

* Fail the build on errors

* Support export * from

* Support `--outfile`

* partially fix renaming

* fanicer symbol renaming impl

* misc, extremely revertible cleanup

* Fix up some bugs with symbol renaming

* formatting

* Update launch.json

* Parse `__PURE__` comments

* clean up simd code for pure comments

* changes to merge

* workaround runtime issue

* Fix issue with `export * as` not propagating correctly

* Make all top-level declarations `var` when bundling

* Fix missing prefix

* Fix assigning to stack copy

* Fix missing runtime symbol

* Fix bug with namespace exports

* Dramatically reduce allocations

* Update launch.json

* Add missing flags

* Update js_parser.zig

* small cleanup

* Make the export name better

* Fix unnecessary `var foo = foo`

* Implement CommonJS -> ESM conversion

* Implement module redirects

* Port esbuild bundler tests for new bundler (#2380)

* started porting esbuild tests

* clean up test names and api before moving on

* port tests using a program i wrote

* replace todo generated comment

* fix generated tests not including some files

* work on tests

* [github web editor] add define, external, inject, minifySyntax, minifyWhitespace options.

* get most of the todo comments out of the way, but expectBundled does not handle most of the cases

* continue working on esbuild tests

* use test.skip for unsupported tests

* Fixups for test runner

* Hoist imports & exports

* Fix test

* Hoist classes

* bundler test refining, 51/835

* Fix runtime require

* bundler test refining, 81/835

* bundler test refining, 93/835

* Make the test work in any timezone

* feat(expect): update toBeInstanceOf (#2396)

* feat: update instanceof binding

* fix: according to PR comments

* Rename `expectObjectTypeCount` to `expectMaxObjectTypeCount`

* Fix socket tests with connection errors (#2403)

* release pending activity with connection error handler

* unref poll_ref

* remove trailing comma

* Organize Dockerfiles for official status

* Remove test Dockerfile

* Remove old Docker workflow

* Feat(test): add toMatch (#2404)

* Fix various fetch/response/request tests (#2416)

* fix most fetch tests, skip a few

* fastGet, toValueGC, and invalid init

* bigint unreachable, range error, log process as process

* remove extra fetch_headers

* remove js_type parameter, check isObject()

* throw invalid mime type error, use enum literal

* switch back to promise rejection

* RangeError pascal case

* Fix several bugs (#2418)

* utf16 codepoint with replacement character

* Fix test failure with `TextEncoder("ascii')`

* Add missing type

* Fix Response.prototype.bodyUsed and Request.prototype.bodyUsed

* Fix bug with scrypt error not clearing

* Update server.zig

* oopsie

* :nail_care:

* docs: Use correct url in the 'Issues' link in README header (#2420)

* Fix crash when rendering error page and the server or network is slow

* [fetch] Make the default body value `null` when unspecified

This is better aligned with the fetch spec

* Make node-net tests less flaky

* [node:net] Fix issue with `listen` callback firing before it's listening

* Always clear timers in node test harness

* Fix out of bounds access

Repro'd in Buffer tests

* Update UWS

cc @cirospaciari

* Make this test more thorough

* Hanging abort test

* 0 length body is a null stream

* Several bug fixes (#2427)

* Fix test

* Fix segfault when unexpected type is passed in `expect().toThrow`

* Fix issues with request constructor

* Don't bother cloning headers when its empty

* woops

* more tests

* fix incorrect test

* Make the fetch error messages better

* Update response.zig

* Fix test that failed on macOS

* Fix test

* Remove extra hash table lookups

* Support running dummy registry directly

cc @alexlamsl

* Update test

* Update test

* fixup

* Workaround crash in test runner

* Fixup test

* Fixup test

* Update os.test.js

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

* Remove usages of port numbers in tests

* Set -O2 and -fno-rtti

* Remove -g

* Prevent undefined memory access

* [bun test] Implement `--rerun-each` flag to run each test N times

* Reduce number of module scopes created

* add some extra abort checks into streams (#2430)

* add some checks to avoid UAF

* avoid multiple calls to finalize if endFromJS is called more than once

* fix no-op comment

* mark as requested_end on abort

* remove requested_end from abort

* remove unnecessary check (#2432)

* Fix bug with scoped aliased dependencies in bun install on macOS

* remove `addLog`, remove `--prominent-compile-errors`

* Finish the upgrade

* Optional chaining flag

* Implement same_target_becomes_destructuring optimization

* bundler test refining, 109/835

* Reset bindings

* Support multiple entry points

* Implement `--entry-names` flag

* Use a tempdir with a better name

* prettier

* Log file name

* Update js_parser.zig

* Mark all bun builtins as external

* Make resolve errors actually errors

* Update bundler_default.test.ts

* Fix `await import(foo)`

* WIP react server components

* Do more stuff at runtime

* :scissors:

* Support automatic JSX imports

* Use a module cache for now

* Update tsconfig.base.json

* Fix ThisOutsideFunctionNotRenamed

* woopsie

* moar cpu

* clamp it

* fixup

* Add a bunch of assertions

* Bun uses automatic runtime by default

* Parse Import Attributes

* Add a note about Valgrind

* Update developing.md

* Fix up code splitting for React Server Components

* Implement client component manifest

* Fix crash with --react-server-components and no client components

* Backport https://github.com/ziglang/zig/commit/4d31e3c917a05541394c544708f0047cfb53331a

* Update launch.json

* Fix for latest zig

* Workaround bug with ?[]const string

Occasionally saw alignment errors in this code

Workaround https://github.com/ziglang/zig/issues/15085

related: https://github.com/ziglang/zig/pull/15089

* switch to regular slice

* Avoid initializing named_imports and named_exports as undefined

* Reduce usages of `undefined`

* Add more assertions

* --watch wip

* Update javascript.zig

* Possibly fix the race condition

* Faster `do`

* bump allocator

* Reduce the size of `Symbol` slightly

* Alphabetically sort runtime import symbols, for determinism

* Prepare for code splitting

* handle overlapping stdout

* pure

* clean up some things

* Fix bug with `$$typeof`

* Address CommonJS -> ESM hoisting bug

* Support `"use server"` in manifest

* Implement `"use server"`

* Fix importing bun builtins when bundling

* Make `commonjs_to_esm` a feature flag, fix some splitting bugs

* :scissors:

* fixme remove this

* Fix crash in longestCommonPath

* Chunking! Just need to do import paths now.

* Import paths work...now trying to figure out how to make runtime symbols work

* add workaround

* Replace `bun bun` with `bun build`

* Fix crash with dual package hazard

* Fix many CommonJS <> ESM interop bugs

* Support package.json `"sideEffects"`

also skip loading unnecessary package.json data in `bun run`

* add a not good --watch implementation

* bundler test refining, 140/831

* remove accidentally committed file

* do not return status code 1 on successful bundles

* bundler test refining, 159/830

* pass exit code to exitOrWatch

* clean up help menu

-remove two spaces to line up bun build
-moved all <r> tags to the end of the text they are colorizing
-moved other colors to the start of the text they colorize
-removed unneeded <r> tags, keeping only one at the start of the block

* importstar is fully ported

* wip

* you can run code in this branch now

* Disable this transform

* organize and document bundler tests

* Fix double import

* Fix sloppy mode function declarations

* Disable our CommonJS transform for now

* add `assertNotPresent` to make splitting cases easier

* Bump!

* Update bun.d.ts

* use import.meta.require in runtime code

* Disable this again

* Fix dirname

* Fix ESM -> CJS wrapper

* :nail_care:

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Alex Lam S.L <alexlamsl@gmail.com>
Co-authored-by: Derrick Farris <mr.dcfarris@gmail.com>
Co-authored-by: Ashcon Partovi <ashcon@partovi.net>
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
Co-authored-by: pfg <pfg@pfg.pw>
Co-authored-by: Colin McDonnell <colinmcd94@gmail.com>
Co-authored-by: dave caruso <me@paperdave.net>
Co-authored-by: zhiyuan <32867472+zhiyuang@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>

1 files changed, 112 insertions, 73 deletions

diff --git a/src/ast/base.zig b/src/ast/base.zig
index f3cc34925..634bd9852 100644
--- a/src/ast/base.zig
+++ b/src/ast/base.zig
@@ -1,4 +1,5 @@
 const std = @import("std");
+const bun = @import("bun");
 const unicode = std.unicode;
 
 pub const JavascriptString = []u16;
@@ -126,94 +127,142 @@ pub inline fn getBits(comptime TargetType: type, target: anytype, comptime start
     return @truncate(TargetType, target >> start_bit);
 }
 
-pub const Ref = enum(TotalSize) {
-    default = std.math.maxInt(TotalSize),
-    _,
+/// In some parts of Bun, we have many different IDs pointing to different things.
+/// It's easy for them to get mixed up, so we use this type to make sure we don't.
+///
+pub const Index = packed struct(u32) {
+    value: Int,
+
+    pub fn set(this: *Index, val: Int) void {
+        this.value = val;
+    }
+
+    pub inline fn isRuntime(this: Index) bool {
+        return this.value == runtime.value;
+    }
+
+    pub const invalid = Index{ .value = std.math.maxInt(Int) };
+    pub const runtime = Index{
+        .value = 0,
+    };
+
+    pub const Int = u32;
+
+    pub inline fn source(num: anytype) Index {
+        return .{ .value = @truncate(Int, num) };
+    }
 
-    pub const TotalSize = u62;
+    pub inline fn part(num: anytype) Index {
+        return .{ .value = @truncate(Int, num) };
+    }
+
+    pub fn init(num: anytype) Index {
+        const NumType = @TypeOf(num);
+        if (comptime @typeInfo(NumType) == .Pointer) {
+            return init(num.*);
+        }
+
+        if (comptime bun.Environment.allow_assert) {
+            return .{
+                .value = @intCast(Int, num),
+            };
+        }
+
+        return .{
+            .value = @intCast(Int, num),
+        };
+    }
+
+    pub inline fn isValid(this: Index) bool {
+        return this.value != invalid.value;
+    }
+
+    pub inline fn isInvalid(this: Index) bool {
+        return !this.isValid();
+    }
+
+    pub inline fn get(this: Index) Int {
+        return this.value;
+    }
+};
+
+pub const Ref = packed struct(u64) {
+    inner_index: Int = 0,
+
+    tag: enum(u2) {
+        invalid,
+        allocated_name,
+        source_contents_slice,
+        symbol,
+    } = .invalid,
+
+    source_index: Int = 0,
+
+    pub inline fn isEmpty(this: Ref) bool {
+        return this.asU64() == 0;
+    }
+
+    pub const ArrayHashCtx = RefHashCtx;
+
+    pub const Int = std.meta.Int(.unsigned, (64 - 2) / 2);
+
+    pub fn toInt(value: anytype) Int {
+        return @intCast(Int, value);
+    }
+
+    pub fn isSourceIndexNull(this: anytype) bool {
+        return this == std.math.maxInt(Int);
+    }
+
+    pub fn isSymbol(this: Ref) bool {
+        return this.tag == .symbol;
+    }
 
     pub fn format(ref: Ref, comptime _: []const u8, _: std.fmt.FormatOptions, writer: anytype) !void {
         try std.fmt.format(
             writer,
-            "Ref: sourceIndex = {d}, innerIndex = {d}, is_source_contents_slice = {}",
+            "Ref[{d}, {d}, {s}]",
             .{
                 ref.sourceIndex(),
                 ref.innerIndex(),
-                ref.isSourceContentsSlice(),
+                @tagName(ref.tag),
             },
         );
     }
 
-    const max_ref_int = std.math.maxInt(Ref.Int);
-    pub const BitInt = std.meta.Int(.unsigned, @bitSizeOf(Ref));
-
-    pub inline fn asBitInt(this: Ref) BitInt {
-        return @bitCast(BitInt, this);
+    pub fn isValid(this: Ref) bool {
+        return this.tag != .invalid;
     }
 
     // 2 bits of padding for whatever is the parent
-    pub const Int = u30;
-    pub const None = Ref.init(std.math.maxInt(u30), std.math.maxInt(u30), false);
-    pub const RuntimeRef = Ref.init(std.math.maxInt(u30), std.math.maxInt(u30) - 1, false);
-
-    const source_index_offset = 1;
-    const inner_index_offset = 1 + 30;
+    pub const None = Ref{ .inner_index = 0, .source_index = 0, .tag = .invalid };
 
     pub inline fn sourceIndex(this: Ref) Int {
-        return @truncate(Int, getBits(TotalSize, @enumToInt(this), source_index_offset, 30));
+        return this.source_index;
     }
 
     pub inline fn innerIndex(this: Ref) Int {
-        return @truncate(Int, getBits(TotalSize, @enumToInt(this), inner_index_offset, 30));
+        return this.inner_index;
     }
 
     pub inline fn isSourceContentsSlice(this: Ref) bool {
-        return (getBits(TotalSize, @enumToInt(this), 0, 1) & 1) != 0;
-    }
-
-    pub fn atIndex(value: anytype) Ref {
-        return @intToEnum(Ref, setBits(TotalSize, 0, inner_index_offset, 30, @truncate(Int, value)));
-    }
-
-    pub fn init(inner_index: Int, source_index: Int, is_source_contents_slice: bool) Ref {
-        return @intToEnum(
-            Ref,
-            setBits(
-                TotalSize,
-                0,
-                0,
-                1,
-                @as(
-                    TotalSize,
-                    @boolToInt(is_source_contents_slice),
-                ),
-            ) | setBits(
-                TotalSize,
-                0,
-                source_index_offset,
-                30,
-                source_index,
-            ) | setBits(
-                TotalSize,
-                0,
-                inner_index_offset,
-                30,
-                inner_index,
-            ),
-        );
+        return this.tag == .source_contents_slice;
     }
 
-    const Old = struct {
-        inner_index: Int = 0,
-        source_index: Int = std.math.maxInt(Int),
-        is_source_contents_slice: bool = false,
-    };
-    pub fn initSourceEnd(old: Old) Ref {
-        return init(old.inner_index, old.source_index, old.is_source_contents_slice);
+    pub fn init(inner_index: Int, source_index: usize, is_source_contents_slice: bool) Ref {
+        return .{
+            .inner_index = inner_index,
+
+            // if we overflow, we want a panic
+            .source_index = @intCast(Int, source_index),
+
+            .tag = if (is_source_contents_slice) .source_contents_slice else .allocated_name,
+        };
     }
 
-    pub fn toInt(int: anytype) Int {
-        return @intCast(Int, int);
+    pub fn initSourceEnd(old: Ref) Ref {
+        std.debug.assert(old.tag != .invalid);
+        return init(old.inner_index, old.source_index, old.tag == .source_contents_slice);
     }
 
     pub fn hash(key: Ref) u32 {
@@ -221,13 +270,7 @@ pub const Ref = enum(TotalSize) {
     }
 
     pub inline fn asU64(key: Ref) u64 {
-        // This type isn't quite a u64 because it is used in a few other packed structs which have variables in them
-        // But, there are some footguns with the stage1 implementation of packed structs
-        // so it is safer to do comparisons as u64
-        // but we want to ensure that the value of the unused bits in the u64 are 0
-        // i have not looked at the assembly to verify that the unused bits default to 0
-        // so we set it to u64 0 just to be sure
-        return @as(u64, @enumToInt(key));
+        return @bitCast(u64, key);
     }
 
     pub inline fn hash64(key: Ref) u64 {
@@ -238,11 +281,7 @@ pub const Ref = enum(TotalSize) {
         return asU64(ref) == b.asU64();
     }
     pub inline fn isNull(self: Ref) bool {
-        return self.eql(Ref.None);
-    }
-
-    pub fn isSourceIndexNull(int: anytype) bool {
-        return int == max_ref_int;
+        return self.tag == .invalid;
     }
 
     pub fn jsonStringify(self: *const Ref, options: anytype, writer: anytype) !void {