diff options
author | 2023-07-05 00:08:59 -0700 | |
---|---|---|
committer | 2023-07-05 00:08:59 -0700 | |
commit | a7f5a91cfbf93a31cc53974a6c27185e57a57f64 (patch) | |
tree | fee9697bf197aff53b1092fac3e12313b9dd7b46 /src/bun.js/api | |
parent | 75816aa3ab5bfbfe054c527d4100e9ebd141bd79 (diff) | |
download | bun-a7f5a91cfbf93a31cc53974a6c27185e57a57f64.tar.gz bun-a7f5a91cfbf93a31cc53974a6c27185e57a57f64.tar.zst bun-a7f5a91cfbf93a31cc53974a6c27185e57a57f64.zip |
Fixes #3520 (#3522)
* Fixes #3520
* Update html_rewriter.zig
---------
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Diffstat (limited to 'src/bun.js/api')
-rw-r--r-- | src/bun.js/api/html_rewriter.zig | 26 |
1 files changed, 8 insertions, 18 deletions
diff --git a/src/bun.js/api/html_rewriter.zig b/src/bun.js/api/html_rewriter.zig index 532e0ae1e..b309e07d7 100644 --- a/src/bun.js/api/html_rewriter.zig +++ b/src/bun.js/api/html_rewriter.zig @@ -1558,27 +1558,16 @@ pub const AttributeIterator = struct { return JSC.JSValue.jsNull(); }; - // TODO: don't clone here const value = attribute.value(); const name = attribute.name(); - defer name.deinit(); - defer value.deinit(); - var strs = [2]ZigString{ - ZigString.init(name.slice()), - ZigString.init(value.slice()), - }; - - var valid_strs: []ZigString = strs[0..2]; - - var array = JSC.JSValue.createStringArray( + return bun.String.toJSArray( globalObject, - valid_strs.ptr, - valid_strs.len, - true, + &[_]bun.String{ + name.toString(), + value.toString(), + }, ); - - return array; } }; pub const Element = struct { @@ -1864,8 +1853,9 @@ pub const Element = struct { pub fn getNamespaceURI(this: *Element, globalObject: *JSGlobalObject) JSValue { if (this.element == null) return JSValue.jsUndefined(); - - return ZigString.init(std.mem.span(this.element.?.namespaceURI())).toValueGC(globalObject); + var str = bun.String.create(std.mem.span(this.element.?.namespaceURI())); + defer str.deref(); + return str.toJS(globalObject); } pub fn getAttributes(this: *Element, globalObject: *JSGlobalObject) JSValue { |