diff options
| author |  Ashcon Partovi <ashcon@partovi.net>
| 2023-08-29 23:44:39 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-08-29 23:44:39 -0700 |
| commit | f2553d24543d72a777ba60213473332809866cb2 (patch) | |
| tree | 61faac4292dbdf1b4d0543e33d3f5d2c792825c5 /src/bun.js/bindings/BunDebugger.cpp | |
| parent | c028b206bce3f9b5c3cba7899c6bf34856efe43f (diff) | |
| download | bun-f2553d24543d72a777ba60213473332809866cb2.tar.gz bun-f2553d24543d72a777ba60213473332809866cb2.tar.zst bun-f2553d24543d72a777ba60213473332809866cb2.zip | |
More support for DAP (#4380)
* Fix reconnect with --watch
* Support setVariable
* Support setExpression
* Support watch variables
* Conditional and hit breakpoints
* Support exceptionInfo
* Support goto and gotoTargets
* Support completions
* Support both a URL and UNIX inspector at the same time
* Fix url
* WIP, add timeouts to figure out issue
* Fix messages being dropped from debugger.ts
* Progress
* Fix breakpoints and ref-event-loop
* More fixes
* Fix exit
* Make hovers better
* Fix --hot
Diffstat (limited to 'src/bun.js/bindings/BunDebugger.cpp')
| -rw-r--r-- | src/bun.js/bindings/BunDebugger.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/bun.js/bindings/BunDebugger.cpp b/src/bun.js/bindings/BunDebugger.cpp index 440a5125b..f4a5f535a 100644 --- a/src/bun.js/bindings/BunDebugger.cpp +++ b/src/bun.js/bindings/BunDebugger.cpp @@ -109,7 +109,7 @@ public: globalObject->setInspectable(true); auto& inspector = globalObject->inspectorDebuggable(); inspector.setInspectable(true); - globalObject->inspectorController().connectFrontend(*connection, true, waitingForConnection); + globalObject->inspectorController().connectFrontend(*connection, true, false); // waitingForConnection Inspector::JSGlobalObjectDebugger* debugger = reinterpret_cast<Inspector::JSGlobalObjectDebugger*>(globalObject->debugger()); if (debugger) { @@ -482,7 +482,7 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionCreateConnection, (JSGlobalObject * globalObj return JSValue::encode(JSBunInspectorConnection::create(vm, JSBunInspectorConnection::createStructure(vm, globalObject, globalObject->objectPrototype()), connection)); } -extern "C" BunString Bun__startJSDebuggerThread(Zig::GlobalObject* debuggerGlobalObject, ScriptExecutionContextIdentifier scriptId, BunString* portOrPathString) +extern "C" void Bun__startJSDebuggerThread(Zig::GlobalObject* debuggerGlobalObject, ScriptExecutionContextIdentifier scriptId, BunString* portOrPathString) { if (!debuggerScriptExecutionContext) debuggerScriptExecutionContext = debuggerGlobalObject->scriptExecutionContext(); @@ -498,12 +498,7 @@ extern "C" BunString Bun__startJSDebuggerThread(Zig::GlobalObject* debuggerGloba arguments.append(JSFunction::create(vm, debuggerGlobalObject, 1, String("send"_s), jsFunctionSend, ImplementationVisibility::Public)); arguments.append(JSFunction::create(vm, debuggerGlobalObject, 0, String("disconnect"_s), jsFunctionDisconnect, ImplementationVisibility::Public)); - JSValue serverURLValue = JSC::call(debuggerGlobalObject, debuggerDefaultFn, arguments, "Bun__initJSDebuggerThread - debuggerDefaultFn"_s); - - if (serverURLValue.isUndefinedOrNull()) - return BunStringEmpty; - - return Bun::toStringRef(debuggerGlobalObject, serverURLValue); + JSC::call(debuggerGlobalObject, debuggerDefaultFn, arguments, "Bun__initJSDebuggerThread - debuggerDefaultFn"_s); } enum class AsyncCallTypeUint8 : uint8_t { |