diff options
| author |  Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
| 2023-05-30 00:26:30 -0700 |
|---|---|---|
| committer | Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
| 2023-05-30 00:26:30 -0700 |
| commit | 85565d95d5f600718d239782d58d06c6c5efc37c (patch) | |
| tree | dd6e168ebaefbbbff2095cb5c27a49f3d56d4646 /src/bun.js/bindings/CommonJSModuleRecord.cpp | |
| parent | fdbf8a51846747067601e309f47136a5550a1d37 (diff) | |
| download | bun-85565d95d5f600718d239782d58d06c6c5efc37c.tar.gz bun-85565d95d5f600718d239782d58d06c6c5efc37c.tar.zst bun-85565d95d5f600718d239782d58d06c6c5efc37c.zip | |
Add a comment
Diffstat (limited to 'src/bun.js/bindings/CommonJSModuleRecord.cpp')
| -rw-r--r-- | src/bun.js/bindings/CommonJSModuleRecord.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/bun.js/bindings/CommonJSModuleRecord.cpp b/src/bun.js/bindings/CommonJSModuleRecord.cpp index f70fff10d..ba49f0e14 100644 --- a/src/bun.js/bindings/CommonJSModuleRecord.cpp +++ b/src/bun.js/bindings/CommonJSModuleRecord.cpp @@ -393,6 +393,10 @@ JSC::SourceCode createCommonJSModule( result = moduleObject->getIfPropertyExists(globalObject, clientData->builtinNames().exportsPublicName()); if (UNLIKELY(throwScope.exception())) { + // Unlike getters on properties of the exports object + // When the exports object itself is a getter and it throws + // There's not a lot we can do + // so we surface that error globalObject->requireMap()->remove(globalObject, requireMapKey); throwScope.release(); return; |