possibly more reliable Bun.spawn (#1547)

* wip

* wip

* Fix bug with stdin

* zig fmt

* seems to work!

* Update streams.test.js

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

1 files changed, 8 insertions, 3 deletions

diff --git a/src/bun.js/bindings/URLSearchParams.cpp b/src/bun.js/bindings/URLSearchParams.cpp
index 0ce9554c7..9c168b4f6 100644
--- a/src/bun.js/bindings/URLSearchParams.cpp
+++ b/src/bun.js/bindings/URLSearchParams.cpp
@@ -96,9 +96,11 @@ void URLSearchParams::set(const String& name, const String& value)
             return false;
         });
         updateURL();
+        needsSorting = true;
         return;
     }
     m_pairs.append({ name, value });
+    needsSorting = true;
     updateURL();
 }
 
@@ -106,6 +108,7 @@ void URLSearchParams::append(const String& name, const String& value)
 {
     m_pairs.append({ name, value });
     updateURL();
+    needsSorting = true;
 }
 
 Vector<String> URLSearchParams::getAll(const String& name) const
@@ -122,10 +125,12 @@ Vector<String> URLSearchParams::getAll(const String& name) const
 
 void URLSearchParams::remove(const String& name)
 {
-    m_pairs.removeAllMatching([&](const auto& pair) {
-        return pair.key == name;
-    });
+    if (!m_pairs.removeAllMatching([&](const auto& pair) {
+            return pair.key == name;
+        }))
+        return;
     updateURL();
+    needsSorting = true;
 }
 
 String URLSearchParams::toString() const