diff options
| author |  dave caruso <me@paperdave.net>
| 2023-08-21 23:39:56 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-08-21 23:39:56 -0700 |
| commit | 52802a4c556d7498d75d00e4fe4e45633f4283e8 (patch) | |
| tree | 9d52b3c386ead79f02e8719c76f301ecfd058d25 /src/bun.js/bindings/napi.cpp | |
| parent | 44e4d5852a1c31e1d124828fa6417d3d1884cdb2 (diff) | |
| download | bun-52802a4c556d7498d75d00e4fe4e45633f4283e8.tar.gz bun-52802a4c556d7498d75d00e4fe4e45633f4283e8.tar.zst bun-52802a4c556d7498d75d00e4fe4e45633f4283e8.zip | |
fix fsevents and stub for qwikcity (#4247)
* fix test
* ok
* cm
* EE
* remove the hack we didnt need
Diffstat (limited to 'src/bun.js/bindings/napi.cpp')
| -rw-r--r-- | src/bun.js/bindings/napi.cpp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/bun.js/bindings/napi.cpp b/src/bun.js/bindings/napi.cpp index 2562242a8..72ca50dcb 100644 --- a/src/bun.js/bindings/napi.cpp +++ b/src/bun.js/bindings/napi.cpp @@ -1766,15 +1766,6 @@ extern "C" napi_status napi_create_external(napi_env env, void* data, auto* structure = Bun::NapiExternal::createStructure(vm, globalObject, globalObject->objectPrototype()); JSValue value = JSValue(Bun::NapiExternal::create(vm, structure, data, finalize_hint, finalize_cb)); - // With `fsevents`, their napi_create_external seems to get immediatly garbage - // collected for some unknown reason. - // See https://github.com/oven-sh/bun/issues/3978 and `fsevents.test.ts` - JSC::Strong<Unknown>* strong = new JSC::Strong<Unknown>(vm, value); - globalObject->scriptExecutionContext()->postTask([strong](auto& context) -> void { - strong->clear(); - delete strong; - }); - *result = toNapi(value); return napi_ok; } |