`node:fs` implement `rm` on macOS

no linux yet

3 files changed, 70 insertions, 1 deletions

diff --git a/src/bun.js/node/node_fs.zig b/src/bun.js/node/node_fs.zig
index 8374e1c77..5fb03f9b6 100644
--- a/src/bun.js/node/node_fs.zig
+++ b/src/bun.js/node/node_fs.zig
@@ -773,6 +773,37 @@ const Arguments = struct {
         max_retries: u32 = 0,
         recursive: bool = false,
         retry_delay: c_uint = 100,
+
+        pub fn fromJS(ctx: JSC.C.JSContextRef, arguments: *ArgumentsSlice, exception: JSC.C.ExceptionRef) ?RmDir {
+            const path = PathLike.fromJS(ctx, arguments, exception) orelse {
+                if (exception.* == null) {
+                    JSC.throwInvalidArguments(
+                        "path must be a string or TypedArray",
+                        .{},
+                        ctx,
+                        exception,
+                    );
+                }
+                return null;
+            };
+
+            if (exception.* != null) return null;
+            var recursive = false;
+            if (arguments.next()) |val| {
+                arguments.eat();
+
+                if (val.isObject()) {
+                    if (val.getIfPropertyExists(ctx.ptr(), "recursive")) |recursive_| {
+                        recursive = recursive_.toBoolean();
+                    }
+                }
+            }
+
+            return RmDir{
+                .path = path,
+                .recursive = recursive,
+            };
+        }
     };
 
     /// https://github.com/nodejs/node/blob/master/lib/fs.js#L1285
@@ -3601,7 +3632,10 @@ pub const NodeFS = struct {
         switch (comptime flavor) {
             .sync => {
                 var dir = args.old_path.sliceZ(&this.sync_error_buf);
-                _ = dir;
+                switch (Syscall.getErrno(system.rmdir(dir))) {
+                    .SUCCESS => return Maybe(Return.Rmdir).success,
+                    else => |err| return Maybe(Return.Rmdir).errnoSys(err, .rmdir),
+                }
             },
             else => {},
         }
@@ -3614,6 +3648,29 @@ pub const NodeFS = struct {
         _ = args;
         _ = this;
         _ = flavor;
+        switch (comptime flavor) {
+            .sync => {
+                var dest = args.path.sliceZ(&this.sync_error_buf);
+
+                if (comptime Environment.isMac) {
+                    var flags: u32 = 0;
+                    if (args.recursive) {
+                        flags |= bun.C.darwin.RemoveFileFlags.cross_mount;
+                        flags |= bun.C.darwin.RemoveFileFlags.allow_long_paths;
+                        flags |= bun.C.darwin.RemoveFileFlags.recursive;
+                    }
+
+                    switch (bun.C.darwin.removefileat(std.os.AT.FDCWD, dest, null, flags)) {
+                        0 => return Maybe(Return.Rm).success,
+                        else => |err| return Maybe(Return.Rm).errnoSys(err, .unlink).?,
+                    }
+                } else if (comptime Environment.isLinux) {
+                    // TODO:
+                }
+            },
+            else => {},
+        }
+
         return Maybe(Return.Rm).todo;
     }
     pub fn stat(this: *NodeFS, args: Arguments.Stat, comptime flavor: Flavor) Maybe(Return.Stat) {
diff --git a/src/bun.js/node/node_fs_binding.zig b/src/bun.js/node/node_fs_binding.zig
index 298727fb9..d4d97e9a9 100644
--- a/src/bun.js/node/node_fs_binding.zig
+++ b/src/bun.js/node/node_fs_binding.zig
@@ -239,6 +239,10 @@ pub const NodeFSBindings = JSC.NewClass(
             .name = "readlink",
             .rfn = call(.readlink),
         },
+        .rm = .{
+            .name = "rm",
+            .rfn = call(.rm),
+        },
         .realpath = .{
             .name = "realpath",
             .rfn = call(.realpath),
@@ -418,6 +422,10 @@ pub const NodeFSBindings = JSC.NewClass(
             .name = "lutimesSync",
             .rfn = callSync(.lutimes),
         },
+        .rmSync = .{
+            .name = "rmSync",
+            .rfn = callSync(.rm),
+        },
     },
     .{},
 );
diff --git a/src/bun.js/node/syscall.zig b/src/bun.js/node/syscall.zig
index d677a4510..fddd0a8df 100644
--- a/src/bun.js/node/syscall.zig
+++ b/src/bun.js/node/syscall.zig
@@ -566,6 +566,10 @@ pub const Error = struct {
     syscall: Syscall.Tag = @intToEnum(Syscall.Tag, 0),
     path: []const u8 = "",
 
+    pub inline fn isRetry(this: *const Error) bool {
+        return this.getErrno() == .AGAIN;
+    }
+
     pub fn fromCode(errno: os.E, syscall: Syscall.Tag) Error {
         return .{ .errno = @truncate(Int, @enumToInt(errno)), .syscall = syscall };
     }