diff options
author | 2023-01-15 02:50:55 +0200 | |
---|---|---|
committer | 2023-01-14 16:50:55 -0800 | |
commit | 136014b13a0df0641cd7d8ff29d8cf41fae92622 (patch) | |
tree | 731efa451049fe7304cf96becda2953e19cca903 /src/cli | |
parent | d01ec47529fb7d035b9d369c1e524abf220c8242 (diff) | |
download | bun-136014b13a0df0641cd7d8ff29d8cf41fae92622.tar.gz bun-136014b13a0df0641cd7d8ff29d8cf41fae92622.tar.zst bun-136014b13a0df0641cd7d8ff29d8cf41fae92622.zip |
fix bugs (#1795)
- segfault reading stacktrace from `fs/promises` rejections
- `Promise` rejection within `describe()` ends testing abruptly
- `FSSink.write()` incorrectly handles `objectMode`
- `FSSink.write()` throws wrong error codes
Diffstat (limited to 'src/cli')
-rw-r--r-- | src/cli/test_command.zig | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/cli/test_command.zig b/src/cli/test_command.zig index a52af87c1..05b5d4058 100644 --- a/src/cli/test_command.zig +++ b/src/cli/test_command.zig @@ -478,7 +478,7 @@ pub const TestCommand = struct { if (reporter.summary.expectations > 0) Output.prettyError(" {d:5>} expect() calls\n", .{reporter.summary.expectations}); Output.prettyError( - \\ Ran {d} tests across {d} files + \\ Ran {d} tests across {d} files , .{ reporter.summary.fail + reporter.summary.pass, test_files.len, @@ -593,8 +593,8 @@ pub const TestCommand = struct { module.runTests(JSC.JSValue.zero, vm.global); vm.eventLoop().tick(); - const initial_unhandled_counter = vm.unhandled_error_counter; - while (vm.active_tasks > 0 and vm.unhandled_error_counter == initial_unhandled_counter) { + var prev_unhandled_count = vm.unhandled_error_counter; + while (vm.active_tasks > 0) { if (!jest.Jest.runner.?.has_pending_tests) jest.Jest.runner.?.drain(); vm.eventLoop().tick(); @@ -603,6 +603,11 @@ pub const TestCommand = struct { if (!jest.Jest.runner.?.has_pending_tests) break; vm.eventLoop().tick(); } + + while (prev_unhandled_count < vm.unhandled_error_counter) { + vm.global.handleRejectedPromises(); + prev_unhandled_count = vm.unhandled_error_counter; + } } _ = vm.global.vm().runGC(false); } |