diff options
| author |  Ai Hoshino <ambiguous404@gmail.com>
| 2023-09-21 09:43:08 +0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-09-20 18:43:08 -0700 |
| commit | 7319142fd866d8314364d769f401a492892f7d63 (patch) | |
| tree | 581466ccd682482f080ad6b8dc41eeb33e2f4626 /src/js/node/dns.js | |
| parent | 365fc0d39ddfaed8683eb6ee75013a0fe3adcae2 (diff) | |
| download | bun-7319142fd866d8314364d769f401a492892f7d63.tar.gz bun-7319142fd866d8314364d769f401a492892f7d63.tar.zst bun-7319142fd866d8314364d769f401a492892f7d63.zip | |
feat(node:dns): implement `dns.lookupService` (#5613)
* feat(node:dns): implement dns.lookupService
Close: #4347
* fix flags
* add `getSockaddr`
* fix sockaddr size
* flaky test
Diffstat (limited to 'src/js/node/dns.js')
| -rw-r--r-- | src/js/node/dns.js | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/js/node/dns.js b/src/js/node/dns.js index a6de07351..7e6fc97dd 100644 --- a/src/js/node/dns.js +++ b/src/js/node/dns.js @@ -176,7 +176,14 @@ function lookupService(address, port, callback) { throw new TypeError("callback must be a function"); } - callback(null, address, port); + dns.lookupService(address, port, callback).then( + results => { + callback(null, ...results); + }, + error => { + callback(error); + }, + ); } function reverse(ip, callback) { @@ -517,7 +524,7 @@ const promises = { }, lookupService(address, port) { - return Promise.resolve([]); + return dns.lookupService(address, port); }, resolve(hostname, rrtype) { |