diff options
| author |  João Alisson <joaoalissonsobral@gmail.com>
| 2023-10-13 21:52:57 -0300 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-10-13 17:52:57 -0700 |
| commit | 851dc9aadc3a419470ce5023863df568443577ae (patch) | |
| tree | 050659537cab3e6f031f67ffaea799bb631342f6 /src/js/node/dns.js | |
| parent | d08e112d416ddee7af8d499524e40e7f193ae55a (diff) | |
| download | bun-851dc9aadc3a419470ce5023863df568443577ae.tar.gz bun-851dc9aadc3a419470ce5023863df568443577ae.tar.zst bun-851dc9aadc3a419470ce5023863df568443577ae.zip | |
fix(node): dns lookup deprecated behavior (#6391)
Co-authored-by: alisson <alisson@Ubuntu.myguest.virtualbox.org>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Diffstat (limited to 'src/js/node/dns.js')
| -rw-r--r-- | src/js/node/dns.js | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/js/node/dns.js b/src/js/node/dns.js index 2dc3895a2..bb59e702f 100644 --- a/src/js/node/dns.js +++ b/src/js/node/dns.js @@ -19,6 +19,19 @@ function lookup(domain, options, callback) { options = { family: options }; } + const invalidDomainValues = [ + undefined, + false, + null, + "" + ]; + + if(Number.isNaN(domain) || invalidDomainValues.some(value => domain === value)) { + console.warn(`DeprecationWarning: The provided hostname "${String(domain)}" is not a valid hostname, and is supported in the dns module solely for compatibility.`); + callback(null, null, 4); + return; + } + dns.lookup(domain, options).then( res => { res.sort((a, b) => a.family - b.family); |